Opened 7 years ago

Closed 7 years ago

#15363 closed defect (fixed)

dojo/store/Observable handle API violates "remove" convention

Reported by: Colin Snover Owned by: Kris Zyp
Priority: blocker Milestone: 1.8
Component: General Version: 1.7.2
Keywords: Cc:
Blocked By: Blocking:

Description

The handle returned by dojo/store/Observable.observe has a "cancel" method. It should have a "remove" method to match all other handles.

Change History (2)

comment:1 Changed 7 years ago by bill

Like #15364, it would be nice to be consistent with other handles, especially for the sake of Destroyable. cancel() could also remain in 1.x, for back-compat.

PS: here's the ​the painful email thread about naming.

PPS: this ticket is certainly not a blocker; it's not even a defect.

comment:2 Changed 7 years ago by Colin Snover

Resolution: → fixed
Status: new → closed

In [28715]:

Add 'remove' method to dojo/store/Observable.observe return handle to match handles from other methods. Fixes #15363.

Note: See TracTickets for help on using tickets.