Chart: Adding new series slides theme

[Mathevet julien]

If you add new series after creating your chart. All series are slide in theme. So Each serie get previous theme color.

It's due that chart render serie from last to first and getting theme with next.

Is there any reason to do that ? Why we iterate in reverse order to render them ?

[cjolif]

Yes asked myself the same question the first time I encountered that and I'm still wondering why series are drawn backward. Only Eugene can answer here. Eugene? On the other hand changing that order now would create an incompatibility. I think a valid wokaround for now is to use Chart.setSeriesOrder or Chart.moveSeriesToXXX after adding your series. Have tried that?

[cjolif]

See also: #16355.

In fact this was the case for example on Columns plot but was not the case on ClusteredColumns?. The refactoring in 1.8 make it true even for plots for which it was not the case previously.

[cjolif]

If that was just for the theming issue I would be tempted to fix that in 1.9 with a release note. However if we iterate the series the other way around (from start to end) this will also have the consequence of inverting the drawing order for the series. This is particularly annoying for line series because it will change which series are on top of each others so it might be harder to accept in term of incompatibility. Opinions?

[Mathevet julien]

You could create a method in SimpleTheme? to getTheme(index)

[Jared Jurkiewicz]

This was resolved in 1.11 under enhancement: ​https://bugs.dojotoolkit.org/ticket/18061 To make all chart plot rendering order consistent.

[cjolif]

As this will be "breaking" existing apps, I would suggest adding something here: ​https://github.com/dojo/docs/blob/master/releasenotes/1.11.rst