Opened 7 years ago

Closed 7 years ago

#15353 closed defect (fixed)

[patch][CLA] Allow non discret value on columns/stacked columns

Reported by: Mathevet julien Owned by: cjolif
Priority: undecided Milestone: 1.8
Component: Charting Version: 1.7.2
Keywords: Cc:
Blocked By: Blocking:

Description

This patch allow non discret value on columns/stacked columns. It's also remove all code in StackedColumns. So It could have styleFunction and shadow.

Like #15308 patch. Reduce code.

This patch need commonStacked.js submit in #15308

Attachments (3)

patchColumns.diff (13.0 KB) - added by Mathevet julien 7 years ago.
patchTestMissingPoints.diff (2.7 KB) - added by Mathevet julien 7 years ago.
Include commit [28565]
15353.diff (30.3 KB) - added by Mathevet julien 7 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 7 years ago by cjolif

Owner: changed from Eugene Lazutkin to cjolif
Status: newassigned

comment:2 Changed 7 years ago by Mathevet julien

I updated patch to include clusteredColumns and clean dependencies declaration. I also try to a do less code change

Changed 7 years ago by Mathevet julien

Attachment: patchColumns.diff added

comment:3 Changed 7 years ago by cjolif

Can you include test case as diff patch against what was committed in [28565]? Thanks.

Changed 7 years ago by Mathevet julien

Attachment: patchTestMissingPoints.diff added

Include commit [28565]

comment:4 Changed 7 years ago by Mathevet julien

If you accept this patch I think you could close also #7926

comment:5 Changed 7 years ago by cjolif

moogle, for consistency reasons for this to be accepted it would need a similar implementation for Bar (not Column) classes. Can you update your patch with that (and the test)? Thanks.

comment:6 Changed 7 years ago by Mathevet julien

I add patch included both Bars and columns fix

Changed 7 years ago by Mathevet julien

Attachment: 15353.diff added

comment:7 Changed 7 years ago by cjolif

In [28591]:

refs #15353. Allow non discrete values for stacked columns/bars as well as support styleFunc & shadow on them. Thanks moogle (CLA).

comment:8 Changed 7 years ago by cjolif

Milestone: tbd1.8

comment:9 Changed 7 years ago by cjolif

In [28604]:

refs #15353, #15308. Test against property being here or not correctly (+ other little cleanups).

comment:10 Changed 7 years ago by cjolif

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.