Opened 7 years ago

Closed 7 years ago

Last modified 6 years ago

#15352 closed defect (fixed)

comment.keeplines doesn't work

Reported by: bill Owned by: Rawld Gill
Priority: low Milestone: 1.8
Component: BuildSystem Version: 1.7.2
Keywords: Cc:
Blocked By: Blocking:

Description

The build documentation says there's a comment.keeplines option to the optimizer. However, it doesn't work:

$ ./build.sh releaseDir=/workspace/webkitBuild action=release optimize=comment.keepLines layerOptimize=comment.keepLines profile=webkitMobile copyTests=true
...
error(319) Unknown optimize value. value: comment.keeplines
error(319) Unknown optimize value. value: comment.keeplines

Change History (5)

comment:1 Changed 7 years ago by bill

If that option is no longer supported, it should be removed from the documentation.

Also, the doc uses different capitalization: comment.keeplines vs. closure.keepLines. If case is important the doc needs to be fixed to whichever case is correct.

Last edited 7 years ago by bill (previous) (diff)

comment:2 Changed 7 years ago by Rawld Gill

Resolution: fixed
Status: newclosed

In [28850]:

fixed error in input checking; fixes #15352; !strict

comment:3 Changed 7 years ago by Rawld Gill

Milestone: tbd1.8
Priority: undecidedlow

@bill: the input is now case insensitive

comment:4 Changed 6 years ago by danorton

This was never actually fixed. I don't know what was fixed, but the documentation and the source seem to have different names for this option:

Doc: comment.keeplines

Source: comments.keeplines

comment:5 Changed 6 years ago by bill

Ah right. OK I updated the doc to say comments.keeplines, see https://github.com/dojo/docs/commit/3b590043ad63e5243b869c2a915e7ea3040ffa35.

Note: See TracTickets for help on using tickets.