Opened 8 years ago

Last modified 3 years ago

#15322 new defect

[patch] [cla] Moveable "jumps" the first time you try and move

Reported by: david Owned by: Eugene Lazutkin
Priority: undecided Milestone: 1.15
Component: DnD Version: 1.7.2
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by david)

When you use Moveable, in some setups the first time you move a node it "jumps" a little. The problem turns out to be that the body's margin and padding are being taken into account when they really don't need to be. (There's a long comment about how pageX/Y are computed, which may be out of date.)

Two possible fixes are attached. Actually, both fixes could probably be applied.

Attachments (2)

dnd.mover.option1.diff (555 bytes) - added by david 8 years ago.
dnd.mover.option2.diff (1.0 KB) - added by david 8 years ago.

Download all attachments as: .zip

Change History (8)

Changed 8 years ago by david

Attachment: dnd.mover.option1.diff added

Changed 8 years ago by david

Attachment: dnd.mover.option2.diff added

comment:1 Changed 8 years ago by david

Description: modified (diff)

comment:2 Changed 8 years ago by bill

Summary: Moveable "jumps" the first time you try and move[patch] Moveable "jumps" the first time you try and move

Hi, do you have a CLA? We have many Davids with CLA's but not sure if you are one of them because I don't have the mapping from trac id to real name.

comment:3 Changed 8 years ago by david

This is David Schontzler. I have a CLA on file.

I didn't do a full set of tests (my dev stack is a bit limited right now) but I wonder if there is a version of browsers where this used to work. According to the comment I removed in diff 2, it seems that pageX and Y may have behaved differently in the past. Either that or some wrong assumptions were being made. I'm not sure.

comment:4 Changed 8 years ago by bill

Summary: [patch] Moveable "jumps" the first time you try and move[patch] [cla] Moveable "jumps" the first time you try and move

Great, thanks! (I'm not sure about the pageX/pageY thing, maybe you are right. I do know that layerX/layerY are deprecated in favor of using pageX/pageY.)

comment:5 Changed 4 years ago by dylan

Milestone: tbd1.12

Consider for 1.12

comment:6 Changed 3 years ago by dylan

Milestone: 1.131.15

Ticket planning... move current 1.13 tickets out to 1.15 to make it easier to move tickets into the 1.13 milestone.

Note: See TracTickets for help on using tickets.