[patch] fix for dojo.style.getNumericStyle

[[email protected]…]

This patch simplifies dojo.style.getNumericStyle() and makes it more reliable.

Index: style.js
===================================================================
--- style.js	(revision 1784)
+++ style.js	(working copy)
@@ -99,11 +99,8 @@
 	var s = dojo.style.getComputedStyle(element, cssSelector);
 	if (s == ''){ return 0; }
 	if (dojo.lang.isUndefined(s)){ return NaN };
-	var match = s.match(/([d.]+)([a-z]*)/);
-	if (!match || !match[1]) 
-		return NaN;
-	var n = Number(match[1]);
-	return (n == 0 || match[2]=='px' ? n : NaN);
+	var match = s.match(/(d+)(px){0,1}/);
+	return	(!match || !match[1]) ? NaN : Number(match[1]);
 }
 
 dojo.style.getMarginWidth = function(node){

[david]

slightly modified patch

[david]

The patch I submitted would work slightly better, but I'm hesitent of applying it until the folks who use this function can test it out.

[psowden]

I assume you meant to reassign to me :-)

This is patch is based on sjmiles' work, it'd probably be better for him to review.

[[email protected]…]

There are a few problems with the simplification:

• The original code is meant to extract the 'units' designation becuase in future we may support units other than just 'px'.
• Non-zero values in non-supported units must return NaN
• Numeric styles can contain decimals (not just integers), so we must allow '.'

[dylan]

Can we close this?

[sjmiles]

Closing this ticket. Please reopen if I missed some important detail.

[(none)]

Milestone 0.4 deleted