Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#15297 closed defect (fixed)

Auto-Require Mis-Mapping ctors in async

Reported by: Kitson Kelly Owned by: bill
Priority: undecided Milestone: 1.8
Component: Parser Version: 1.7.2
Keywords: Cc:
Blocked By: Blocking:

Description

In certain scenarios it seems the parser is mis-matching constructors when running in async mode.

I am investigating the root of the defect and the attached examples will demonstrate the issue. When run in async, there are issues with the TabContainer and when async is turned off, the page renders properly.

Attachments (3)

15297debugging.patch (2.6 KB) - added by bill 8 years ago.
adding debugging print statements to show problem behavior. see the messages in the console following the "_WidgetsInTemplateMixin calling parser" message
parser_test3.html (1.3 KB) - added by Kitson Kelly 8 years ago.
Minimal "broken" test case
simple.html (247 bytes) - added by Kitson Kelly 8 years ago.
Content for minimal test case

Download all attachments as: .zip

Change History (9)

comment:1 Changed 8 years ago by bill

BTW that test file is working fine for me.... oh wait nevermind, I see I need to edit the file to set async:true.

Last edited 8 years ago by bill (previous) (diff)

Changed 8 years ago by bill

Attachment: 15297debugging.patch added

adding debugging print statements to show problem behavior. see the messages in the console following the "_WidgetsInTemplateMixin calling parser" message

Changed 8 years ago by Kitson Kelly

Attachment: parser_test3.html added

Minimal "broken" test case

Changed 8 years ago by Kitson Kelly

Attachment: simple.html added

Content for minimal test case

comment:2 Changed 8 years ago by Kitson Kelly

Updated with minimal "broken" test case.

comment:3 Changed 8 years ago by Mark Wubben

In [28526]:

When chaining promises, immediately signal deferred for non-promise or fulfilled-promise results.

Refs #15297, #14615 !strict

comment:4 Changed 8 years ago by Mark Wubben

I've committed a fix to Deferred which should resolve this issue. The test cases seem to pass for me, kitsonk could you confirm?

comment:5 Changed 8 years ago by Kitson Kelly

Resolution: fixed
Status: newclosed

Yup, works like a charm. Everything resolves like anticipated. Thanks!!!!

comment:6 Changed 8 years ago by bill

Milestone: tbd1.8
Note: See TracTickets for help on using tickets.