Opened 8 years ago

Closed 8 years ago

#15293 closed defect (fixed)

dijit.ProgressBar breaks if no params object is passed to constructor

Reported by: Kenneth G. Franqueiro Owned by: Kenneth G. Franqueiro
Priority: undecided Milestone: 1.8
Component: Dijit Version: 1.7.2
Keywords: Cc:
Blocked By: Blocking:

Description

dijit.ProgressBar's postMixInProperties method performs an in operation on this.params, which assumes it is defined. However, it won't be if the constructor is called with no arguments, which will result in an error.

See http://bugs.dojotoolkit.org/browser/dojo/branches/1.7/dijit/ProgressBar.js#L80

Should be simple enough to fix with an extra check for this.params first.

Change History (2)

comment:1 Changed 8 years ago by Kenneth G. Franqueiro

Milestone: tbd1.8
Owner: set to Kenneth G. Franqueiro
Status: newassigned

Marking this as 1.8 as per discussion with csnover, since the milestone is still currently open. Should be simple enough to fix, I'll see if I can get it done later tonight.

comment:2 Changed 8 years ago by Kenneth G. Franqueiro

Resolution: fixed
Status: assignedclosed

In [28491]:

Do not assume existence of this.params in ProgressBar#postMixInProperties?; fixes #15293

Note: See TracTickets for help on using tickets.