Opened 7 years ago

Closed 7 years ago

#15274 closed enhancement (fixed)

make simpleFetch based classes more extendable

Reported by: Karl Tiedt Owned by: Karl Tiedt
Priority: undecided Milestone: 1.8
Component: Data Version: 1.7.2
Keywords: Cc:
Blocked By: Blocking:

Description

This attached patch exposes _errorHandler and _fetchHandler in the SimpleFetch? closure as this.fetchHandler and this.errorHandler so DataStore?'s can be extended w/the ability to modify these methods

I've done a quick check and no existing DataStores? in dojo/data or dojox/data use these names and ran through some of the test pages and they appear to all be working...

Attachments (1)

simpleFetch.patch​ (7.8 KB) - added by Karl Tiedt 7 years ago.
allow simpleFetch methods to be extendable by future DataStore? subclasses

Download all attachments as: .zip

Change History (4)

comment:1 Changed 7 years ago by Karl Tiedt

Milestone: tbd → 1.8
Owner: changed from Kris Zyp to Karl Tiedt
Status: new → assigned

comment:2 Changed 7 years ago by Karl Tiedt

Type: defect → enhancement

Changed 7 years ago by Karl Tiedt

Attachment: simpleFetch.patch​ added

allow simpleFetch methods to be extendable by future DataStore? subclasses

comment:3 Changed 7 years ago by Karl Tiedt

Resolution: → fixed
Status: assigned → closed

In [28484]:

Updating simpleFetch to allow for extendable methods vs private closure wrapped untouchable functions. Fixes #15274

Note: See TracTickets for help on using tickets.