[cla] [patch] Update dojox.widget.FisheyeList to AMD format

[Karl Tiedt]

Update FisheyeList? to AMD format (similar to FisheyeLite?) - Allows for Fisheye or its ListItems? to be easily extended.

Note: this is not a full AMD local var conversion, this is just a "as much as needed to keep things working" but allow AMD support.

[Adam Peller]

can you use _WidgetBase instead of _Widget?

[Karl Tiedt]

Revised patch, full AMD support now

[Karl Tiedt]

Updated to widgetBase and did a full AMD update - it makes sense to do it. Can someone verify that on/connect stuff is correct - I tested with our application and the test page and all appears to work as expected)

[bill]

Thanks for the full conversion.

The on() calls look good to me. About handle.remove() vs. dojo.disconnect(handle), the only caution I've found is that dojo.disconnect(handle) won't complain when handle is null or undefined, whereas handle.remove() will throw an exception. But as long as the handles are guaranteed to be set, you're OK.

If you really wanted to do an update to all the latest API's then I guess the

// this.on() does not work for addChild 
this.connect(this, "addChild", "_initializePositioning"); 

would be converted to:

this._adoptHandles(
   aspect.after(this, "addChild", lang.hitch(this, "_initializePositioning"), true)
);

(because this.connect() needs to go away in 2.0 since dojo.connect() is going away)

[Karl Tiedt]

Ahhh _adoptHandles apparently is trunk only? at least it is not in our 1.7.2 project, will make that update though and get this committed

[Karl Tiedt]

Looking at how _adoptHandles works this is perfectly legal right?

        this._adoptHandles(
            aspect.after(this, "addChild", lang.hitch(this, "_initializePositioning"), true),
            aspect.after(winUtil.global, "onresize", lang.hitch(this, "_initializePositioning"), true)
        );

[bill]

Replying to ktiedt:

Looking at how _adoptHandles works this is perfectly legal right?

        this._adoptHandles(
            aspect.after(this, "addChild", lang.hitch(this, "_initializePositioning"), true),
            aspect.after(winUtil.global, "onresize", lang.hitch(this, "_initializePositioning"), true)
        );

Yup, that's the intended usage.

[Karl Tiedt]

In [28441]:

Fixes #15248 - Separate Fisheyelist/ListItem? into 2 separate files 2 allow for extending 1 or the other and converted to full AMD and updated all calls to use non deprecated code paths - also updated test file for AMD usage.

[bill]

In [28447]:

Fix typo, plus remove direct <script> tag (since it's illegal in the world of AMD), refs #15248 !strict.

[Karl Tiedt]

In [28481]:

Missed update to data-dojo-attach-point in templateString and need to start the conservative trigger handler regardless of initial value, then pause/resume as needed. Refs #15248

[ben hockey]

don't forget to update dojox/dojox.profile.js so that these converted files get tagged as amd. ie update the excludes array so that these module ids aren't going to match any more.

[Colin Snover]

1.8 is frozen. Move all enhancements to next release. If you need an exemption from the freeze for this ticket, contact me immediately.

[bill]

See neonstalwart's comment above.

[bill]

In [29239]:

Update dojox.profile.js with modules converted to AMD, fixes #15248, #15301, refs #13101,