Opened 10 years ago
Closed 10 years ago
#15248 closed enhancement (fixed)
[cla] [patch] Update dojox.widget.FisheyeList to AMD format
Reported by: | Karl Tiedt | Owned by: | Karl Tiedt |
---|---|---|---|
Priority: | undecided | Milestone: | 1.8 |
Component: | DojoX Widgets | Version: | 1.7.2 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
Update FisheyeList? to AMD format (similar to FisheyeLite?) - Allows for Fisheye or its ListItems? to be easily extended.
Note: this is not a full AMD local var conversion, this is just a "as much as needed to keep things working" but allow AMD support.
Attachments (1)
Change History (16)
comment:1 Changed 10 years ago by
Owner: | changed from dante to Karl Tiedt |
---|---|
Status: | new → assigned |
comment:2 Changed 10 years ago by
Changed 10 years ago by
Attachment: | dojoxFisheyeList.patch added |
---|
Revised patch, full AMD support now
comment:3 Changed 10 years ago by
Updated to widgetBase and did a full AMD update - it makes sense to do it. Can someone verify that on/connect stuff is correct - I tested with our application and the test page and all appears to work as expected)
comment:4 Changed 10 years ago by
Thanks for the full conversion.
The on() calls look good to me. About handle.remove()
vs. dojo.disconnect(handle)
, the only caution I've found is that dojo.disconnect(handle)
won't complain when handle is null or undefined, whereas handle.remove()
will throw an exception. But as long as the handles are guaranteed to be set, you're OK.
If you really wanted to do an update to all the latest API's then I guess the
// this.on() does not work for addChild this.connect(this, "addChild", "_initializePositioning");
would be converted to:
this._adoptHandles( aspect.after(this, "addChild", lang.hitch(this, "_initializePositioning"), true) );
(because this.connect() needs to go away in 2.0 since dojo.connect() is going away)
comment:5 Changed 10 years ago by
Ahhh _adoptHandles apparently is trunk only? at least it is not in our 1.7.2 project, will make that update though and get this committed
comment:6 follow-up: 8 Changed 10 years ago by
Looking at how _adoptHandles works this is perfectly legal right?
this._adoptHandles( aspect.after(this, "addChild", lang.hitch(this, "_initializePositioning"), true), aspect.after(winUtil.global, "onresize", lang.hitch(this, "_initializePositioning"), true) );
comment:7 Changed 10 years ago by
Milestone: | tbd → 1.8 |
---|
comment:8 Changed 10 years ago by
Replying to ktiedt:
Looking at how _adoptHandles works this is perfectly legal right?
this._adoptHandles( aspect.after(this, "addChild", lang.hitch(this, "_initializePositioning"), true), aspect.after(winUtil.global, "onresize", lang.hitch(this, "_initializePositioning"), true) );
Yup, that's the intended usage.
comment:12 Changed 10 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
don't forget to update dojox/dojox.profile.js so that these converted files get tagged as amd. ie update the excludes array so that these module ids aren't going to match any more.
comment:13 Changed 10 years ago by
Milestone: | 1.8 → 2.0 |
---|
1.8 is frozen. Move all enhancements to next release. If you need an exemption from the freeze for this ticket, contact me immediately.
can you use _WidgetBase instead of _Widget?