Opened 7 years ago

Closed 7 years ago

#15179 closed defect (fixed)

Since several days a lot of nightly build test cases fail: _39e is not defined

Reported by: Paul Christopher Owned by: ben hockey
Priority: blocker Milestone: 1.8
Component: Core Version:
Keywords: Cc:
Blocked By: Blocking:

Description

Something seems to be broken in the build versions of Dojo (since a week or so?).

Check e.g.

http://archive.dojotoolkit.org/nightly/dojotoolkit/dijit/tests/form/test_Select.html --> _39e is not defined

http://archive.dojotoolkit.org/nightly/dojotoolkit/dijit/tests/form/test_FilteringSelect.html --> Click on the arrow of the first drop down list so as to open it --> _39e is not defined

I have encountered this error a week ago when playing around with the new calendar widget, see https://github.com/damiengarbarino/dojo-calendar/issues/15.

With the calendar widget, the error fades away when I replace the compressed version by the uncompressed version of dojo.js.

Change History (4)

comment:1 Changed 7 years ago by ben hockey

Component: GeneralCore
Owner: set to Mark Wubben
Priority: undecidedblocker
Status: newassigned

this is a manifestation of a longstanding shrinksafe bug (#11673). assigning to mark wubben to fix. mark, don't use named functions - it's a problem with shrinksafe. ie - don't do this:

return lang.extend(function Deferred() {
  ...

  this.then = function () {
    ...
    listener.deferred = new Deferred();  // this reference will be minified (to _39e in this case) but the named function stays as Deferred
  };

});

comment:2 Changed 7 years ago by Mark Wubben

In [28351]:

Remove use of named functions, refs #15179 !strict.

Linting fixes, refs #14615 !strict.

comment:3 Changed 7 years ago by Mark Wubben

Owner: changed from Mark Wubben to ben hockey

Uhm, OK. Better now?

comment:4 Changed 7 years ago by ben hockey

Milestone: tbd1.8
Resolution: fixed
Status: assignedclosed

i don't see the issue now. seems to be fixed. thanks.

Note: See TracTickets for help on using tickets.