Opened 8 years ago

Closed 8 years ago

#15171 closed enhancement (fixed)

dojox.mvc API suggestions

Reported by: Ed Chatelain Owned by: Ed Chatelain
Priority: undecided Milestone: 1.8
Component: DojoX MVC Version: 1.7.2
Keywords: Cc:
Blocked By: Blocking:

Description

We have received the following dojox.mvc API suggestions. Change attach() -> transform(), there seems to be agreement on this change. Another suggestion was to change direct() to setDirection(). Which I also think makes sense.

Attachments (1)

mvc-api-15171.patch (208.6 KB) - added by Ed Chatelain 8 years ago.
Updates to change attach() to transform() and direct() to direction() along with a lot of testcase updates for this and for the global at() change.

Download all attachments as: .zip

Change History (4)

comment:1 Changed 8 years ago by Ed Chatelain

Milestone: tbd1.8
Status: newassigned

So for an example, this: <input id="totalHousing" data-dojo-type="dijit.form.NumberTextBox?"

data-dojo-props="value: at('rel:', 'TotalHousing?'),

disabled: at('rel:','TotalHousing?').direct(at.from).attach(nonZeroRelevanceConverter)"/>

Would change to: <input id="totalHousing" data-dojo-type="dijit.form.NumberTextBox?"

data-dojo-props="value: at('rel:', 'TotalHousing?'),

disabled: at('rel:','TotalHousing?').setDirection(at.from).transorm(nonZeroRelevanceConverter)"/>

comment:2 Changed 8 years ago by Ed Chatelain

Well I got feedback not liking setDirection(), so I will change it to .direction(), and I will change the property being used in at and sync to be bindDirection. So now would change to: <input id="totalHousing" data-dojo-type="dijit.form.NumberTextBox??"

data-dojo-props="value: at('rel:', 'TotalHousing??'),

disabled: at('rel:','TotalHousing??').direction(at.from).transorm(nonZeroRelevanceConverter)"/>

Version 0, edited 8 years ago by Ed Chatelain (next)

Changed 8 years ago by Ed Chatelain

Attachment: mvc-api-15171.patch added

Updates to change attach() to transform() and direct() to direction() along with a lot of testcase updates for this and for the global at() change.

comment:3 Changed 8 years ago by cjolif

Resolution: fixed
Status: assignedclosed

In [28342]:

fixes #15171. Updates to change attach() to transform() and direct() to direction() along with a lot of testcase updates for this and for the global at() change. Thanks edchat (IBM, CCLA). !strict.

Note: See TracTickets for help on using tickets.