Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#15166 closed enhancement (fixed)

[CLA] [PATCH] Update AndOr*Stores to understand numeric query operators

Reported by: Karl Tiedt Owned by: Karl Tiedt
Priority: undecided Milestone: 1.8
Component: DojoX Data Version: 1.7.2
Keywords: Cc:
Blocked By: Blocking:

Description

We have recently patched AndOrReadStore? to understand:

, >=, <, <= and based on feed back from Bill, will be submitting the patch

Opening this ticket as a self reminder and to track the commit that will be associated with it.

Attachments (2)

DataStores.patch (89.3 KB) - added by Karl Tiedt 7 years ago.
Makes ItemFile?* Stores more extendable vs copy/pastable
ItemFileAndOr.patch (96.2 KB) - added by Karl Tiedt 7 years ago.
Updated patch to include more comments

Download all attachments as: .zip

Change History (7)

comment:1 Changed 7 years ago by Karl Tiedt

Owner: changed from Kris Zyp to Karl Tiedt
Status: newassigned

Changed 7 years ago by Karl Tiedt

Attachment: DataStores.patch added

Makes ItemFile?* Stores more extendable vs copy/pastable

comment:2 Changed 7 years ago by Karl Tiedt

Ok so this is a bit more than *just* the AndOr?* changes... because the best way to make these changes was to fix the underlying problem with ItemFile?* based Stores... It separates filter() from _fetchItems so extended stores can now just replace this.filter() instead of copying all of _fetchItems just to modify 1 basic function of the store.

Note: this patch wont affect legacy DataStores? based on IFR/WS since they all blow away _fetchItem anyways.. but it reduces existing files by over 1600 LOC

Posting the patch for now: its been mildy tested against some of our massive project, but not against the dojo tests yet... would prefer to give any review opportunities a chance before or "wtf this is too massive a change, just fix the one file instead" comments out the way.

comment:3 Changed 7 years ago by Karl Tiedt

Summary: [CLA] Update AndOr*Stores to understand numeric query operators[CLA] [PATCH] Update AndOr*Stores to understand numeric query operators

Changed 7 years ago by Karl Tiedt

Attachment: ItemFileAndOr.patch added

Updated patch to include more comments

comment:4 Changed 7 years ago by Karl Tiedt

Resolution: fixed
Status: assignedclosed

In [28416]:

Fixes #15166 - This makes ItemFileRead/Write? stores extendable and then properly extends them to make AndOrRead/WriteStore?'s ~1600 lines of code less. !strict

comment:5 Changed 7 years ago by Karl Tiedt

Milestone: tbd1.8

Updating milestone since nobody objected to this being in 1.8

Note: See TracTickets for help on using tickets.