Opened 7 years ago

Closed 4 years ago

#15156 closed defect (fixed)

[patch][cla][pr] dojo.store.DataStore won't set implicit idProperty properly

Reported by: juk Owned by: dylan
Priority: high Milestone: 1.8.11
Component: Data Version: 1.7.2
Keywords: Cc:
Blocked By: Blocking:

Description

There are missing parentheses in expression

!"idProperty" in options

which is always false. Also, following line

this.idProperty = (!idAttribute || !idAttributes[0]) || this.idProperty; 

is not doing what I guess it's supposed to do, see attached patch.

Attachments (1)

patch (1.0 KB) - added by juk 7 years ago.

Download all attachments as: .zip

Change History (5)

Changed 7 years ago by juk

Attachment: patch added

comment:1 Changed 5 years ago by dylan

Milestone: tbd1.11
Owner: changed from Kris Zyp to dylan
Priority: undecidedhigh
Status: newassigned

comment:3 Changed 4 years ago by dylan

Summary: dojo.store.DataStore won't set implicit idProperty properly[patch][cla][pr] dojo.store.DataStore won't set implicit idProperty properly
Note: See TracTickets for help on using tickets.