Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#15141 closed defect (fixed)

InlineEditBox: Select edit widget doesn't work

Reported by: milad Owned by: Douglas Hays
Priority: undecided Milestone: 1.8
Component: Dijit Version: 1.7.2
Keywords: Cc:
Blocked By: Blocking:

Description

hi all i trying to use diji.form.Select with dijit.InlineEditBox?,but it seem InlineEditBox? don't call startup() to load item. see attachment pls

Attachments (2)

option.zip (1.2 KB) - added by milad 8 years ago.
15141.patch (11.7 KB) - added by Douglas Hays 8 years ago.
possible fix

Download all attachments as: .zip

Change History (13)

Changed 8 years ago by milad

Attachment: option.zip added

comment:1 Changed 8 years ago by bill

In [28296]:

Call startup() on edit widget, refs #15141 !strict. Also capitalizing class names as per convention (and to avoid JSHint warnings).

comment:2 Changed 8 years ago by bill

Owner: set to Douglas Hays
Status: newassigned
Summary: InlineEditBox not calling startup() when using dijit.form.SelectInlineEditBox: Select edit widget doesn't work

@doughays - I tried adding a startup() call on the edit widget, but that exposes another problem, where Select asynchronously calls onChange() on initialization, when the data store (in attached test case option.zip) finishes loading the data from the URL. That means that the first click on the InlineEditBox displays the Select, but then it immediately closes.

Can you fix that, and add this test case to test_InlineEditbox (and associated robot test files)?

comment:3 Changed 8 years ago by Douglas Hays

Milestone: tbd1.8

ooghry, can you test with the attached patch?

comment:4 Changed 8 years ago by milad

no,i don't know what file and where the changed,can you help me?

comment:5 Changed 8 years ago by Douglas Hays

ooghry, you should be able to see the changes by clicking on the 15141.patch link in this defect. Files in tests/* are not necessary for the fix but are just for internal testing.

comment:6 Changed 8 years ago by milad

i done every thing and i don't get error but i have still problem
can you change the file and send them for me?

Changed 8 years ago by Douglas Hays

Attachment: 15141.patch added

possible fix

comment:7 Changed 8 years ago by Douglas Hays

Resolution: fixed
Status: assignedclosed

In [28344]:

Fixes #15141. Add onLoadDeferred to Select so that InlineEditBox? waits for the value to be set. Added various automated tests. !strict

comment:8 Changed 8 years ago by milad

@doughays can you see line 389 file form/_FormSelectWidget.js in 15141.patch,i think diff is wrong.
i try trunk version but it use dojo/when,sniff,promise and ... my problem still remains
do you think i solve my problem with another way?

comment:9 Changed 8 years ago by Douglas Hays

The appended testcase option.zip seems to work for me against trunk. You should be able to do an svn extract to get the latest trunk and then run your option.zip test against that source.

comment:10 Changed 8 years ago by milad

tnx doughays,my first problem is solved,but i think it have 1 or 2 bug.
1:in option.zip,when i change drop down,dojo show value of item as label
2:in option.zip>option.json if i specify selected item with "selected":"selected" or "selected":true,dijit doesn't select value,i hope it's not my fault

comment:11 Changed 8 years ago by Douglas Hays

ooghry, please don't append closed defects with additional issues, and never with how-to questions. Also, labels are displayed, values are submitted with forms, and selected is an attribute of OPTION tags, not of stores. Use the value attribute instead in the outer widget to set the initial value. If you find an additional problem after testing with the latest trunk, please open another ticket and append a new testcase.

Note: See TracTickets for help on using tickets.