Opened 13 years ago

Closed 13 years ago

Last modified 12 years ago

#1514 closed defect (fixed)

dojo.lfx.wipeIn()/wipeOut() should set display:none; wiped-out item still takes up screen space

Reported by: bill Owned by: Bryan Forbes
Priority: high Milestone:
Component: lfx Version: 0.3
Keywords: Cc:
Blocked By: Blocking:

Description

Imagine this markup:

<div style="border: 2px black;">
  <div dojoType=TitlePane label=page1>....</div>
  <div dojoType=TitlePane label=page2>....</div>
  <div dojoType=TitlePane label=page3>....</div>
</div>

If you click the label on page2, then page2 should shrink down to just display the title, and page3 should slide up. But I think currently it doesn't work, after change [5108]. Page2's content becomes invisible but it still takes up space.

Attachments (1)

lfx.patch (385 bytes) - added by ted@… 13 years ago.
Patch to src/lfx/html.js

Download all attachments as: .zip

Change History (7)

comment:1 Changed 13 years ago by dylan

Milestone: 0.4

comment:2 Changed 13 years ago by ted@…

I am attaching a patch which fixed the problem for us.

Changed 13 years ago by ted@…

Attachment: lfx.patch added

Patch to src/lfx/html.js

comment:3 Changed 13 years ago by bill

Hmm, your patch doesn't actually set display:none, but it does fix "taking up screen space" problem, so I will checkin but leave this bug open.

comment:4 Changed 13 years ago by bill

(In [6007]) Fix so collapsed items don't take up screen space (references #1514)

comment:5 Changed 13 years ago by bill

Resolution: fixed
Status: newclosed

I'm gonna close this bug a file a new one for the remaining problems w/wipeIn()/wipeOut().

comment:6 Changed 12 years ago by (none)

Milestone: 0.4

Milestone 0.4 deleted

Note: See TracTickets for help on using tickets.