#15134 closed defect (fixed)
dijit/Editor nested in dijit/form/Form causes error in IE
Reported by: | adros | Owned by: | Ed Hager |
---|---|---|---|
Priority: | blocker | Milestone: | 1.9.3 |
Component: | Editor | Version: | 1.7.2 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
If Editor is nested in Form, getValue function is called before the Editor is loaded (called by connectChildren of _FormMixin). getValue function applies filters, and one of the filter (_stripBreakerNodes, registred for IE) uses this.window, which is undefined before onLoad is called.
I think that another condition needs to be added to getValue function. For example:
if (this.textarea) { if (this.isClosed || !this.isLoaded) { return this.textarea.value; } } else if (!this.isLoaded) { return ... }
Change History (12)
comment:1 Changed 9 years ago by
Resolution: | → duplicate |
---|---|
Status: | new → closed |
comment:2 Changed 7 years ago by
Milestone: | tbd → 1.9.3 |
---|---|
Priority: | undecided → blocker |
Resolution: | duplicate |
Status: | closed → reopened |
comment:3 Changed 7 years ago by
Owner: | set to Ed Hager |
---|---|
Status: | reopened → assigned |
For more information, this issue was reintroduced in a4b34a345d3daa981ed0199d1795ca477817e082
comment:6 Changed 7 years ago by
The patch looks good, assuming that the correct editor value is returned. It just needs an automated test that creates an Editor and then immediately queries the value. (The Editor doesn't need to be inside a form per se.)
Obviously, #15030 shouldn't have been checked in w/out a test case, or we wouldn't have had this regression in the first place.
comment:7 Changed 7 years ago by
Bill, can we make this change for 1.9.3, or do you want an additional test before it gets made. We would like to get 1.9.3 released this week and this is the last blocker.
comment:8 Changed 7 years ago by
The behavior looks wrong, get("value") is returning "" instead of the actual value of the editor.
comment:9 Changed 7 years ago by
Updates:
- I made the editor return
this.value
before the iframe loads - removed a line from
open
that was deletingthis.value
- added test cases retrieving the editor's value before the iframe loads
Commit: https://github.com/edhager/dijit/commit/1e5f39cc4811b3b4b53e1c9ac2f2ec1f6ffb217a Pull Request: https://github.com/dojo/dijit/pull/21
comment:10 Changed 7 years ago by
Bill, I think this addresses everything, and I also had Ed remove the spurious delete this.value as well. Ready for your review/testing.
comment:11 Changed 7 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Duplicate of #15030.