Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#15129 closed defect (fixed)

form/_TextBoxMixin.js (missing semicolon and useless if to undef)

Reported by: mm Owned by: Douglas Hays
Priority: undecided Milestone: 1.8
Component: Dijit - Form Version: 1.7.2
Keywords: Cc:
Blocked By: Blocking:

Description

Please see attached patch

Attachments (1)

patch (1.1 KB) - added by mm 7 years ago.

Download all attachments as: .zip

Change History (8)

Changed 7 years ago by mm

Attachment: patch added

comment:1 Changed 7 years ago by bill

Component: GeneralDijit - Form
Owner: set to Douglas Hays

comment:2 Changed 7 years ago by Douglas Hays

mm, why is the if useless?

comment:3 Changed 7 years ago by mm

uff.... formattedValue != null && formattedValue != undefined

undefined !=null is false

if(x==null) is true for both undefined and null, so undless you go for clockfords === and !== teher is no diff between those two.

comment:4 Changed 7 years ago by mm

also the compare to undef is inconsistent ion the source code sometimes typeof v != "undefined" is used and sometimes v != undefined is used

not a nice style, sorry....

comment:6 Changed 7 years ago by Douglas Hays

Resolution: fixed
Status: newclosed

In [28283]:

Fixes #15129. Combine null and undefined conditionals when appropriate since null==undefined. Add missing semicolons on statements before right braces.

comment:7 Changed 7 years ago by bill

Milestone: tbd1.8

Bulk update for closed tickets marked as tbd/future. Presumably these should be marked as fixed in 1.8.

Note: See TracTickets for help on using tickets.