Opened 9 years ago
Closed 9 years ago
#15125 closed defect (fixed)
Calendar: Impossible to select 'Elul' and 'Sivan' month in Hebrew Calendar/DateTextBox
Reported by: | barbossusus | Owned by: | Adam Peller |
---|---|---|---|
Priority: | undecided | Milestone: | 1.8 |
Component: | Dijit | Version: | 1.7.2 |
Keywords: | Cc: | [email protected]… | |
Blocked By: | Blocking: |
Description (last modified by )
As a user, presented with a Herbew Calendar/DateTextBox control, I am unable to select either 'Elul' or 'Sivan' months. The year changes instead, for instance, from 5772 to 5773.
Expected result: 'Elul' or 'Sivan' months should be displayed as this is the month user clicked
Workaround: Select Tirshi and select Elul again. This way Elul will be selected in Date time Picker.
Attachments (1)
Change History (12)
comment:1 Changed 9 years ago by
Component: | General → Dojox |
---|---|
Description: | modified (diff) |
Owner: | set to Adam Peller |
Status: | new → assigned |
comment:2 Changed 9 years ago by
Cc: | [email protected]… added |
---|
Actually, using test_DateTextBoxNewHebrewGreg.html, I can select Sivan and Elul just fine, but when I go to Tishri is when it goes to the previous year. Also, the problem you mentioned, Bill, with the month names coming up in English, except when I go to a leap year, and the one leap month is in Hebrew. Both of these cases worked fine for me in 1.7.
Helena, can you or someone on your team take a look?
comment:3 Changed 9 years ago by
Hi again, I forgot to mention that I was using dijit/form/DateTextBox and dijit/Calendar. Please let me know if you need more info. Thanks.
comment:5 Changed 9 years ago by
r28467 should change the problem with the missing Hebrew translations, but I still see strange behaviors mentioned above switching dates. Helena, can you take a look?
comment:6 Changed 9 years ago by
Summary: | Impossible to select 'Elul' and 'Sivan' month in Herbew Calendar/DateTextBox → Impossible to select 'Elul' and 'Sivan' month in Hebrew Calendar/DateTextBox |
---|
The add month logic in the Hebrew calendar conflicts with what's expected by the dijit.Calendar code.
Helena noticed that this regression appeared when add was used in the Calendar month dropdown code in place of setMonth several releases ago. Perhaps we could go back to setMonth as a workaround?
comment:7 Changed 9 years ago by
But, we changed from setMonth() to add() in [22886], to fix a bug that:
If the date is something like December 31, 2008 (see DateTextBox.html test, first example) Clicking on February should land you somewhere in February, arguably on the last day of the month. Instead, it selects March with no selected date.
See #10091.
I'm OK with using setMonth() again if that problem can be fixed another way.
Changed 9 years ago by
Attachment: | Calendar.js.patch added |
---|
proposed workaround to dijit.Calendar from Helena (IBM, CCLA)
comment:8 Changed 9 years ago by
Helena also noticed that the comment should probably refer to Feb 28 rather than Jan 28
comment:9 Changed 9 years ago by
Milestone: | tbd → 1.8 |
---|
comment:10 Changed 9 years ago by
Component: | Dojox → Dijit |
---|---|
Summary: | Impossible to select 'Elul' and 'Sivan' month in Hebrew Calendar/DateTextBox → Calendar: Impossible to select 'Elul' and 'Sivan' month in Hebrew Calendar/DateTextBox |
I guess this is the dojox/date code? I tried dojox/date/tests/test_DateTextBoxNewHebrewGreg.html though and I don't see the problem, although I do see another issue that the month names switched from Hebrew to Roman characters between 1.7 and trunk.