Opened 8 years ago

Closed 7 years ago

#15125 closed defect (fixed)

Calendar: Impossible to select 'Elul' and 'Sivan' month in Hebrew Calendar/DateTextBox

Reported by: barbossusus Owned by: Adam Peller
Priority: undecided Milestone: 1.8
Component: Dijit Version: 1.7.2
Keywords: Cc: HHELENA@…
Blocked By: Blocking:

Description (last modified by bill)

As a user, presented with a Herbew Calendar/DateTextBox control, I am unable to select either 'Elul' or 'Sivan' months. The year changes instead, for instance, from 5772 to 5773.

Expected result: 'Elul' or 'Sivan' months should be displayed as this is the month user clicked

Workaround: Select Tirshi and select Elul again. This way Elul will be selected in Date time Picker.

Attachments (1)

Calendar.js.patch (875 bytes) - added by Adam Peller 8 years ago.
proposed workaround to dijit.Calendar from Helena (IBM, CCLA)

Download all attachments as: .zip

Change History (12)

comment:1 Changed 8 years ago by bill

Component: GeneralDojox
Description: modified (diff)
Owner: set to Adam Peller
Status: newassigned

I guess this is the dojox/date code? I tried dojox/date/tests/test_DateTextBoxNewHebrewGreg.html though and I don't see the problem, although I do see another issue that the month names switched from Hebrew to Roman characters between 1.7 and trunk.

comment:2 Changed 8 years ago by Adam Peller

Cc: HHELENA@… added

Actually, using test_DateTextBoxNewHebrewGreg.html, I can select Sivan and Elul just fine, but when I go to Tishri is when it goes to the previous year. Also, the problem you mentioned, Bill, with the month names coming up in English, except when I go to a leap year, and the one leap month is in Hebrew. Both of these cases worked fine for me in 1.7.

Helena, can you or someone on your team take a look?

Last edited 8 years ago by Adam Peller (previous) (diff)

comment:3 Changed 8 years ago by barbossusus

Hi again, I forgot to mention that I was using dijit/form/DateTextBox and dijit/Calendar. Please let me know if you need more info. Thanks.

comment:4 Changed 8 years ago by Adam Peller

In [28467]:

refs #13906 #15125 update CLDR 2.0 with updated build scripts

comment:5 Changed 8 years ago by Adam Peller

r28467 should change the problem with the missing Hebrew translations, but I still see strange behaviors mentioned above switching dates. Helena, can you take a look?

comment:6 Changed 8 years ago by Adam Peller

Summary: Impossible to select 'Elul' and 'Sivan' month in Herbew Calendar/DateTextBoxImpossible to select 'Elul' and 'Sivan' month in Hebrew Calendar/DateTextBox

The add month logic in the Hebrew calendar conflicts with what's expected by the dijit.Calendar code.

Helena noticed that this regression appeared when add was used in the Calendar month dropdown code in place of setMonth several releases ago. Perhaps we could go back to setMonth as a workaround?

comment:7 Changed 8 years ago by bill

But, we changed from setMonth() to add() in [22886], to fix a bug that:

If the date is something like December 31, 2008 (see DateTextBox.html test, first example) Clicking on February should land you somewhere in February, arguably on the last day of the month. Instead, it selects March with no selected date.

See #10091.

I'm OK with using setMonth() again if that problem can be fixed another way.

Changed 8 years ago by Adam Peller

Attachment: Calendar.js.patch added

proposed workaround to dijit.Calendar from Helena (IBM, CCLA)

comment:8 Changed 8 years ago by Adam Peller

Helena also noticed that the comment should probably refer to Feb 28 rather than Jan 28

comment:9 Changed 7 years ago by bill

Milestone: tbd1.8

comment:10 Changed 7 years ago by bill

Component: DojoxDijit
Summary: Impossible to select 'Elul' and 'Sivan' month in Hebrew Calendar/DateTextBoxCalendar: Impossible to select 'Elul' and 'Sivan' month in Hebrew Calendar/DateTextBox

comment:11 Changed 7 years ago by bill

Resolution: fixed
Status: assignedclosed

In [29224]:

Fix selecting 'Elul' and 'Sivan' months from drop down in Calendar with Hebrew date class, fixes #15125 !strict. Patch from Helena Halperin (IBM, CCLA), thanks!

Note: See TracTickets for help on using tickets.