Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#15100 closed defect (fixed)

http is missing in CDN link

Reported by: Simon Speich Owned by: dylan
Priority: high Milestone: 1.7.3
Component: Website Version: 1.7.2
Keywords: Cc: snover
Blocked By: Blocking:

Description

The link to the CDN is broken, because http is missing:

<script src="//ajax.googleapis.com/ajax/libs/dojo/1.7.2/dojo/dojo.js"></script>

should be

<script src="http://ajax.googleapis.com/ajax/libs/dojo/1.7.2/dojo/dojo.js"></script>

Change History (7)

comment:1 Changed 8 years ago by Adam Peller

Owner: changed from itorrey to Simon Speich
Status: newpending

where is this link?

comment:2 Changed 8 years ago by Simon Speich

Status: pendingnew

sorry, stupid me, on the download page: http://dojotoolkit.org/download/

comment:3 Changed 8 years ago by Adam Peller

Cc: snover added
Owner: changed from Simon Speich to itorrey
Status: newassigned

comment:4 Changed 8 years ago by dylan

Milestone: tbd1.7.3
Owner: changed from itorrey to dylan
Priority: undecidedhigh

Index: index.php =================================================================== --- index.php (revision 1848) +++ index.php (working copy) @@ -48,7 +48,7 @@

</label> </div> <p class="codeSample">

  • <span>&lt;script src="<span id="cdnLink">ajax.googleapis.com/ajax/libs/dojo/1.7.2/dojo/dojo.js</span>"&gt;&lt;/script&gt;</span>

+ <span>&lt;script src="<span id="cdnLink">http://ajax.googleapis.com/ajax/libs/dojo/1.7.2/dojo/dojo.js</span>"&gt;&lt;/script&gt;</span>

</p> <p>Copy and paste into your webpage and read the <a href="/documentation/tutorials/1.7/hello_dojo/">Hello Dojo</a> tutorial.</p>

</li>

default@hubbabubba[~/dojo/dojosite/download]$ At revision 1884. svn ci -m "add missing http: in cdn link for google" Sending download/index.php Transmitting file data . Committed revision 1885.

comment:5 Changed 8 years ago by Simon Speich

Hi dylan, it was nice to meet you in Béziers! (Please forgive the spam)

comment:6 Changed 8 years ago by dylan

Resolution: fixed
Status: assignedclosed

Pushed live by Robert Chady.

Thanks Simon, it was great meeting you as well.

comment:7 Changed 7 years ago by Claus Conrad

Hi,

I am wondering why this was "fixed" instead of being closed as "wontfix"?

The previous URL was valid, as Google's CDN provides the libraries through both protocols. By specifying an explicit protocol, developers including the CDN version on a https site risk displaying security warnings to their users.

Best regards, Claus

Note: See TracTickets for help on using tickets.