Opened 7 years ago

Closed 7 years ago

#15083 closed defect (fixed)

dijit.tests._base.place failure in small window

Reported by: haysmark Owned by: bill
Priority: undecided Milestone: 1.8
Component: Dijit Version: 1.7.2
Keywords: dohfail Cc:
Blocked By: Blocking:

Description (last modified by haysmark)

In Dojo 1.7.X, when I run the dijit tests in FF3.6, I get the following failures:

    _AssertFailure: http://192.168.0.105/ibm/fep/FeP_AjaxRuntime/ajax-rt_1.X/dojo/dojo.js:347 assertTrue('false') failed with hint:
  ends after around node
     ERROR IN:
  (function placeOnScreenAroundNodeML(t) {var ret = dijit.placeOnScreenAroundNode(popup, aroundLeft, {BR: "TR", MR: "ML", ML: "MR", TR: "BR"});doh.is("MR", ret.aroundCorner, "around middle");doh.is("ML", ret.corner, "popup's middle");var popupPos = dojo.position(popup);var aroundPos = dojo.position(aroundLeft);doh.is(aroundPos.x + aroundPos.w, popupPos.x, "after around node");doh.t(aroundPos.y > popupPos.y, "starts before around node");doh.t(aroundPos.y < popupPos.y + popupPos.h, "ends after around node");})
 FAILED test: ../../dijit/tests/_base/place.html::dijit._base.place::placeOnScreenAroundNodeML 35 ms
 
     _AssertFailure: http://192.168.0.105/ibm/fep/FeP_AjaxRuntime/ajax-rt_1.X/dojo/dojo.js:347 assertEqual() failed:
  expected BM but got TR with hint: around middle
     ERROR IN:
  (function placeOnScreenAroundNodeMLB(t) {var ret = dijit.placeOnScreenAroundNode(popup, aroundLeft, {BR: "TR", BM: "TM", TR: "BR"});doh.is("BM", ret.aroundCorner, "around middle");doh.is("TM", ret.corner, "popup's middle");var popupPos = dojo.position(popup);var aroundPos = dojo.position(aroundLeft);doh.is(aroundPos.y + aroundPos.h, popupPos.y, "below around node");doh.is(aroundPos.x, popupPos.x, "left aligned with around node");})
 FAILED test: ../../dijit/tests/_base/place.html::dijit._base.place::placeOnScreenAroundNodeMLB 37 ms
 

Test passes in FF10.

Change History (4)

comment:1 Changed 7 years ago by haysmark

Keywords: dohfail added

comment:2 Changed 7 years ago by haysmark

Description: modified (diff)
Summary: dijit.tests._base.place FF10 failuresdijit.tests._base.place FF3.6 failures

comment:3 Changed 7 years ago by bill

Milestone: tbd1.8
Owner: set to bill
Status: newassigned
Summary: dijit.tests._base.place FF3.6 failuresdijit.tests._base.place failure in small window

The failures can happen on any browser, but they are dependent on the viewport size. They happen when the viewport (not including firebug) is small. I'll try to make the test less fragile.

comment:4 Changed 7 years ago by bill

Resolution: fixed
Status: assignedclosed

In [28277]:

Fix tests to be more resilient to small viewport sizes, fixes #15083.

Note: See TracTickets for help on using tickets.