Opened 7 years ago

Closed 7 years ago

#15075 closed enhancement (fixed)

dojox.mobile: mobile gallery demo improvements

Reported by: Adrian Vasiliu Owned by: cjolif
Priority: undecided Milestone: 1.8
Component: Website Version:
Keywords: Cc: Eric Durocher, Soyhy Lim
Blocked By: Blocking:

Description

This is a ticket to collect various enhancements needed in demos/mobileGallery for Dojo 1.8.

Attachments (9)

patch15075a.txt​ (4.2 KB) - added by Adrian Vasiliu 7 years ago.
Adrian Vasiliu, IBM, CCLA
patch15075a.patch​ (4.2 KB) - added by Adrian Vasiliu 7 years ago.
Adrian Vasiliu, IBM, CCLA
patch15075b.patch​ (20.6 KB) - added by Adrian Vasiliu 7 years ago.
Adrian Vasiliu, IBM, CCLA
15075.patch​ (135.2 KB) - added by Eric Durocher 7 years ago.
Enhancements to the mobile gallery, new views showing Dojo Mobile 1.8 features - Adrian Vasiliu (IBM, CCLA), Soyhy Lim (IBM, CCLA), Eric Durocher (IBM, CCLA)
mobileGallery-images.zip​ (123.1 KB) - added by Eric Durocher 7 years ago.
News images for mobileGallery, to extract in demos/mobileGallery/images - Adrian Vasiliu (IBM, CCLA), Soyhy Lim (IBM, CCLA), Eric Durocher (IBM, CCLA)
15075.2.patch​ (26.9 KB) - added by Eric Durocher 7 years ago.
New version of "picker" demo + various fixes and cosmetic changes - Eric Durocher (IBM, CCLA), Soyhy Lim (IBM, CCLA)
15075.3.patch​ (2.5 KB) - added by Eric Durocher 7 years ago.
Fix in value picker demo ('pm' button not taken into account) - Soyhy Lim (IBM, CCLA)
15075.4.patch​ (9.1 KB) - added by Eric Durocher 7 years ago.
Several new fixes in mobile gallery demo - Eric Durocher (IBM, CCLA)
navigation_list_all_29.png​ (21.7 KB) - added by Eric Durocher 7 years ago.
binary file for patch 4

Download all attachments as: .zip

Change History (32)

Changed 7 years ago by Adrian Vasiliu

Attachment: patch15075a.txt​ added

Adrian Vasiliu, IBM, CCLA

comment:1 Changed 7 years ago by Adrian Vasiliu

Attachment patch15075a.txt addresses the following minor issues: a) Added missing type="text/javascript". b) Improved DOCTYPE.

comment:2 Changed 7 years ago by ykami

Component: DojoX Mobile → Website
Owner: changed from ykami to cjolif
Status: new → assigned

Changed 7 years ago by Adrian Vasiliu

Attachment: patch15075a.patch​ added

Adrian Vasiliu, IBM, CCLA

comment:3 Changed 7 years ago by Adrian Vasiliu

Reattached the first patch with the .patch suffix.

comment:4 Changed 7 years ago by Adrian Vasiliu

Further improvements may include:

  • Use the deviceTheme module instead of the demo.html + demo-android.html + demo-iphone.html.
  • Removal of demo-sync.html (got confirmation from chirsm, awaiting confirmation from Archer).

comment:5 Changed 7 years ago by cjolif

Milestone: tbd → 1.8
Summary: dojox.mobile: mobile galery demo improvements → dojox.mobile: mobile gallery demo improvements

comment:6 Changed 7 years ago by Adrian Vasiliu

Attachment patch15075b.patch addresses the removal of two obsolete/useless files: mobileGallery/debug.html mobileGallery/demo-sync.html (Have checked it out with chrism and Archer).

comment:7 Changed 7 years ago by cjolif

Adrian for simple changes like that can you please just update the existing patch to simplify the commit? (i.e. minimize the number of patches to apply).

Thanks.

Last edited 7 years ago by cjolif (previous) (diff)

Changed 7 years ago by Adrian Vasiliu

Attachment: patch15075b.patch​ added

Adrian Vasiliu, IBM, CCLA

comment:8 Changed 7 years ago by Adrian Vasiliu

Understood. Reattached patch15075b.patch, which now accumulates all changes done so far.

Changed 7 years ago by Eric Durocher

Attachment: 15075.patch​ added

Enhancements to the mobile gallery, new views showing Dojo Mobile 1.8 features - Adrian Vasiliu (IBM, CCLA), Soyhy Lim (IBM, CCLA), Eric Durocher (IBM, CCLA)

comment:9 Changed 7 years ago by Eric Durocher

Cc: Eric Durocher Soyhy Lim added

Changed 7 years ago by Eric Durocher

Attachment: mobileGallery-images.zip​ added

News images for mobileGallery, to extract in demos/mobileGallery/images - Adrian Vasiliu (IBM, CCLA), Soyhy Lim (IBM, CCLA), Eric Durocher (IBM, CCLA)

comment:10 Changed 7 years ago by cjolif

In [28352]:

refs #15075. Enhancements to the mobile gallery, new views showing Dojo Mobile 1.8 features. Thanks Adrian Vasiliu (IBM, CCLA), Soyhy Lim (IBM, CCLA), Eric Durocher (IBM, CCLA). !strict.

comment:11 Changed 7 years ago by cjolif

In [28353]:

refs #15075. Forgotten image.

comment:12 Changed 7 years ago by cjolif

In [28354]:

refs #15075. Put a revision number in the cache.

comment:13 Changed 7 years ago by Eric Durocher

Please also copy these two directories from the Dojo Mobile tests:

dojox/mobile/tests/audio/ -> demos/mobileGallery/audio/
dojox/mobile/tests/video/ -> demos/mobileGallery/video/

(3 files called sample.* in each directory).

Eric Durocher (IBM, CCLA)

comment:14 Changed 7 years ago by cjolif

In [28355]:

refs #15075. Add video/audio from dojox/mobile into the demo.

comment:15 Changed 7 years ago by cjolif

In [28356]:

refs #15075. Remove rev as it won't solve the cache pb issue anyway.

comment:16 Changed 7 years ago by cjolif

In [28368]:

refs #15075. Add an image missing in previous commit.

comment:17 Changed 7 years ago by cjolif

In [28370]:

refs #15075. Put back HTML5 doctype that was apparently wrongly removed. Add a forgotten file.

Changed 7 years ago by Eric Durocher

Attachment: 15075.2.patch​ added

New version of "picker" demo + various fixes and cosmetic changes - Eric Durocher (IBM, CCLA), Soyhy Lim (IBM, CCLA)

comment:18 Changed 7 years ago by cjolif

In [28389]:

refs #15075. New version of "picker" demo + various fixes and cosmetic changes. Thank Eric Durocher (IBM, CCLA), Soyhy Lim (IBM, CCLA).

comment:19 Changed 7 years ago by cjolif

In [28395]:

refs #15075. Fix in value picker demo ('pm' button not taken into account) - Soyhy Lim (IBM, CCLA)

Changed 7 years ago by Eric Durocher

Attachment: 15075.3.patch​ added

Fix in value picker demo ('pm' button not taken into account) - Soyhy Lim (IBM, CCLA)

comment:20 Changed 7 years ago by cjolif

In [28396]:

refs #15075. Fix the doc as well in additoin to code.

Changed 7 years ago by Eric Durocher

Attachment: 15075.4.patch​ added

Several new fixes in mobile gallery demo - Eric Durocher (IBM, CCLA)

Changed 7 years ago by Eric Durocher

Attachment: navigation_list_all_29.png​ added

binary file for patch 4

comment:21 Changed 7 years ago by cjolif

In [28546]:

refs #15075. Several new fixes in mobile gallery demo - Thanks Eric Durocher (IBM, CCLA). !strict.

comment:22 Changed 7 years ago by cjolif

In [28547]:

refs #15075. Updated image. Thanks Eric Durocher (IBM, CCLA).

comment:23 Changed 7 years ago by cjolif

Resolution: → fixed
Status: assigned → closed
Note: See TracTickets for help on using tickets.