Opened 8 years ago

Closed 8 years ago

#15068 closed defect (fixed)

_AutoCompleterMixin changes predefined ID of label node

Reported by: Paul Christopher Owned by: Douglas Hays
Priority: undecided Milestone: 1.8
Component: Dijit - Form Version: 1.7.2
Keywords: Cc:
Blocked By: Blocking:

Description

Description

The predefined ID of a control's label node is changed by the postCreate function of _AutoCompleterMixin without checking if there is already an ID present.

Steps to reproduce the issue

Run the attached test case to see the effect. The id of the label is changed from the given value "fruitLabel" to "fruit_label". Thus you cannot access the label with this predefined ID anymore.

Discussion

I think this happens in the _AutoCompleterMixin's postCreate function.

Background: I have a form in which you can enable/disable certain parts by checking a check box. It the control is disabled, if want to gray out the label, too. Therefore I access the label directly via its id.

Workaround: Query the whole DOM and find the label associated the the FilteringSelect ("_AutoCompleterMixin based Widget").

Attachments (2)

testLabel.html (978 bytes) - added by Paul Christopher 8 years ago.
[patch][cla]15068.diff (536 bytes) - added by Paul Christopher 8 years ago.

Download all attachments as: .zip

Change History (4)

Changed 8 years ago by Paul Christopher

Attachment: testLabel.html added

Changed 8 years ago by Paul Christopher

Attachment: [patch][cla]15068.diff added

comment:1 Changed 8 years ago by Douglas Hays

Milestone: tbd1.8
Status: newassigned

comment:2 Changed 8 years ago by Douglas Hays

Resolution: fixed
Status: assignedclosed

In [28238]:

Fixes #15068. Don't overwrite existing label id.

Note: See TracTickets for help on using tickets.