Dialog: focus.focus() error on page unload (IE6-8)

[bill]

(reported by Stephan Hesmer)

See attached testcase. Click button to open dialog, and then click link in dialog, which navigates to a new page. IE gets an exception.

More Details:

When the page unloads, only IE runs a _destroyAll for the dijit.registry (which is to help prevent memory leaks). As it is destroying, the DialogLevelManager.hide inside the dijit Dialog.js is called, which attempts to call focus.focus() and this fails. Because it's trying to restore focus to the Button that triggered the Dialog, but that Button has already been destroyed.

Looking at dojo 1.6, the _DialogLevelManager used dijit.focus(focus) instead, and surrounded it in try/catch statements to discard the error when it occurs.

IMPORTANT: This issue only happens on IE7 and IE8 directly, not on IE9 in IE8 mode.

[bill]

In [28212]:

Account for exception on closing a Dialog when the DialogLevelManager tries to refocus the button that launched the Dialog, but gets an error. Happens on page unload on IE when the dijit.form.Button that launched the Dialog is destroyed before the Dialog. Fixes #15058 on trunk/ !strict.

[bill]

In [28213]:

Account for exception on closing a Dialog when the DialogLevelManager? tries to refocus the button that launched the Dialog, but gets an error. Happens on page unload on IE when the dijit.form.Button that launched the Dialog is destroyed before the Dialog. Fixes #15058 on 1.7/ branch !strict.

[bill]

#15603 is a duplicate of this ticket.