Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#15056 closed defect (fixed)

[patch] IE8: dom-style::getComputedStyle can return null

Reported by: jbest Owned by: Eugene Lazutkin
Priority: undecided Milestone: 1.8
Component: HTML Version: 1.7.2
Keywords: IE8 Cc:
Blocked By: Blocking:

Description

See comment under http://msdn.microsoft.com/en-us/library/ms535231.aspx

There are situations where currentStyle can be null.

Attachments (2)

15056.patch (839 bytes) - added by jbest 8 years ago.
Additional check of currentStyle
15056_test.patch (2.4 KB) - added by jbest 8 years ago.

Download all attachments as: .zip

Change History (12)

Changed 8 years ago by jbest

Attachment: 15056.patch added

Additional check of currentStyle

comment:1 Changed 8 years ago by bill

Component: GeneralHTML
Owner: set to Eugene Lazutkin

Thanks for the patch.

Please attach a test case using the "attach file" button. It should be as small as possible to still reproduce the problem, ideally a single HTML file. And also, instructions on how to reproduce the problem using that test file. Thanks!

comment:2 Changed 8 years ago by bill

Owner: changed from Eugene Lazutkin to jbest
Status: newpending

Changed 8 years ago by jbest

Attachment: 15056_test.patch added

comment:3 Changed 8 years ago by jbest

Status: pendingnew

Attachment (15056_test.patch) added by ticket reporter.

comment:4 Changed 8 years ago by jbest

Added test for dom-style. Running this test against IE8 will fail with the node created via document.createElement. Applying the patch resolves it.

comment:5 Changed 8 years ago by Eugene Lazutkin

The patch looks fine to me. Probably we need to add the comment explaining the problem (currentStyle on IE can be null), so we can remove it later when IE8 dies like it should.

comment:6 Changed 8 years ago by bill

Owner: changed from jbest to Eugene Lazutkin
Status: newassigned

comment:7 Changed 8 years ago by Eugene Lazutkin

Milestone: tbd1.8
Summary: IE8: dom-style::getComputedStyle can return null[patch] IE8: dom-style::getComputedStyle can return null

comment:8 Changed 8 years ago by Eugene Lazutkin

In [28239]:

dom-style: added a chaeck to guard against currentStyle being null on IE8, refs #15056, !strick, thx jbest!

comment:9 Changed 8 years ago by Eugene Lazutkin

Resolution: fixed
Status: assignedclosed

comment:10 Changed 8 years ago by dylan

Keywords: IE8 added

We're trying to make an effort to backport browser bugs to 1.5.x, 1.6.x, and 1.7.x. I believe this one should be considered for that effort.

Note: See TracTickets for help on using tickets.