Opened 7 years ago

Closed 7 years ago

#15028 closed defect (fixed)

dojox.mvc.Repeat problem on IE with the dojox.mobile.parser

Reported by: Ed Chatelain Owned by: ykami
Priority: high Milestone: 1.8
Component: DojoX MVC Version: 1.7.2
Keywords: Cc:
Blocked By: Blocking:

Description

There is a dojox.mvc.Repeat problem on IE with the dojox.mobile.parser,

This test is failing on IE, dojox/mvc/tests/doh_mvc_mobile-demo.html It is failing on the Repeat Data Binding Example page because the textboxes are not being set correctly from the model.

This test works with the dojo/parser but not with the dojox/mobile/parser.

Attachments (2)

parser.js.patch (581 bytes) - added by Akira Sudoh 7 years ago.
Patch to dojox/mobile/parser.js to work around a problem with to-string-conversion of DOMNode._skip
doh_mvc_new_ref-set-repeat.html (8.6 KB) - added by Ed Chatelain 7 years ago.
A simplier testcase to see the problem, place this in dojox/mvc/tests I modified this test to use the dojox.mobile.parser.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 7 years ago by Ed Chatelain

Akira Sudoh reported the following "I found that there is a case where the check in dojox.mobile.parser to skip DOM nodes for stopParser (if(n._skip) fails, though I reproduce that in one web server and don’t in another web server, using the exact same code and exact same browser, which is very weird. When such symptom happens, my IE seems to treat property assignment to DOM node as assigning a value to DOM attribute. It’ll cause dojox.mvc.Repeat.postscript() eventually pick up skip=“undefined” attribute as the template HTML, and eventually set the template HTML back to DOM, and when the parser runs against template HTML, n._skip there becomes string “undefined”, which is not expected by the if block in question.

Changed 7 years ago by Akira Sudoh

Attachment: parser.js.patch added

Patch to dojox/mobile/parser.js to work around a problem with to-string-conversion of DOMNode._skip

Changed 7 years ago by Ed Chatelain

A simplier testcase to see the problem, place this in dojox/mvc/tests I modified this test to use the dojox.mobile.parser.

comment:2 Changed 7 years ago by ykami

Milestone: tbd1.8
Owner: changed from Ed Chatelain to ykami
Priority: undecidedhigh
Status: newassigned

The patch looks ok. I'll apply it to dojox.mobile.parser.

comment:3 Changed 7 years ago by ykami

Resolution: fixed
Status: assignedclosed

In [28208]:

Fixes #15028 !strict. Avoid error on IE by changing the value type for node._skip to string. Thanks asudoh for the patch.

Note: See TracTickets for help on using tickets.