Opened 8 years ago

Closed 8 years ago

#15025 closed defect (fixed)

DnD images in theme folders causes accessibility failure

Reported by: mikeb Owned by: bill
Priority: undecided Milestone: 1.8
Component: Dijit - LnF Version: 1.7.2
Keywords: Cc:
Blocked By: Blocking:

Description

Icons for an "allowed" copy or drop in DnD package only differ from the "not allowed" versions by a color change.

This is not accessible because a colorblind user will not be able to distinguish from an allowable drop or not. A fix was created a few years ago by changing the "No" icons to also use different symbols: http://bugs.dojotoolkit.org/ticket/8557

Somehow these symbols were not used in the theme files.

Fix: Replace

dijit/themes/[nihilo|soria|tundra]/images/dndNoCopy.png dijit/themes/[nihilo|soria|tundra]/images/dndNoMove.png

with:

dojo/resources/images/dndNoCopy.png dojo/resources/images/dndNoMove.png

Replace

dijit/themes/claro/images/dnd.png with the attached image

Also, perhaps we should update the dojo/tests/dnd/test_dnd.html page to use claro. Without a theme it falls back to the images located in dojo/resources, which are correct, which is probably why nobody noticed it.

Attachments (1)

dnd.png (2.1 KB) - added by mikeb 8 years ago.
single image for claro css sprites

Download all attachments as: .zip

Change History (3)

Changed 8 years ago by mikeb

Attachment: dnd.png added

single image for claro css sprites

comment:1 Changed 8 years ago by bill

Component: DnDDijit - LnF
Milestone: tbd1.8
Owner: changed from Eugene Lazutkin to bill
Status: newassigned
Summary: Missing DnD images in theme folders causes accessibility failureDnD images in theme folders causes accessibility failure

There's a sort of "political" issue with having dojo/tests/dnd/test_dnd.html use claro (or other themes) because dojo core is supposed to exist independently from dijit.

But I'll copy over the images like you suggested (including the sprite), thanks!

comment:2 Changed 8 years ago by bill

Resolution: fixed
Status: assignedclosed

In [28179]:

Accessible DnD images for dijit themes, fixes #15025, refs #8557.

Note: See TracTickets for help on using tickets.