Opened 13 years ago

Closed 13 years ago

Last modified 12 years ago

#1502 closed defect (fixed)

Spinner broken by revision 5765 (src/validate/common.js)

Reported by: Douglas Hays Owned by: tk
Priority: high Milestone:
Component: Validate Version: 0.3
Keywords: Cc: Douglas Hays
Blocked By: Blocking:

Description

The change by ktiedt to src/validate/common.js to remove commas from numbers works well if the number only contains commas and digits, but often they contain other separators that are language-specific. Spinner tests this by setting random separator characters. test_SPinner.html now contains several failing tests. Ticket #1152 was already open to fix isInRange when an acceptable solution could be found in 0.5. For this ticket, the change to isInRange should be backed out for 0.4.

Change History (5)

comment:1 Changed 13 years ago by dylan

Owner: changed from dylan to tk
Version: 0.40.3

comment:2 Changed 13 years ago by Karl Tiedt

Resolution: fixed
Status: newclosed

(In [5828]) Made validate.isInRange() check for a separator passed via flags, if passed it removes it and uses isNaN comparison, otherwise it behaves as previously with isNaN commented out. Fixes #1502

comment:3 Changed 12 years ago by (none)

Milestone: 0.4

Milestone 0.4 deleted

comment:4 Changed 12 years ago by Douglas Hays

Cc: Douglas Hays added; doughays@… removed

comment:5 Changed 12 years ago by Douglas Hays

Reporter: changed from doughays@… to Douglas Hays
Note: See TracTickets for help on using tickets.