#15016 closed defect (fixed)
Tooltip: after/before position broken in claro
Reported by: | Karl Tiedt | Owned by: | bill |
---|---|---|---|
Priority: | undecided | Milestone: | 1.7.3 |
Component: | Dijit | Version: | 1.7.2 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
http://downloads.dojotoolkit.org/release-1.7.2/dojo-release-1.7.2/dijit/themes/themeTester.html
Expand the Popups and Alerts accordion, then mouse over the before/after tooltip areas... the arrows are not connected positioned to the tooltip
Change History (10)
comment:1 Changed 10 years ago by
Milestone: | tbd → 1.7.3 |
---|---|
Summary: | dijit.Tooltip after/before position broken in claro → Tooltip: after/before position broken in claro |
comment:2 Changed 10 years ago by
Owner: | set to bill |
---|---|
Status: | new → assigned |
comment:5 Changed 10 years ago by
I saw those actually, and [27718] sounds like before/after *should* work like they used to (which would be expected for backwards-compat) based on the commit message.
comment:6 Changed 10 years ago by
Bill, is it safe to say that "above/below/before/after" are all deprecated and no longer officially supported? If so we might want to include mapping above/below the same way you did before/after
If so then I'll refrain from mentioning the next thing we noticed involving above-centered + above.
comment:7 Changed 10 years ago by
Hmm, well I'm recommending above-centered/below-centered rather than above/below as I think they look nicer, but I wasn't thinking so far as deprecated. Although maybe I'll change my mind when I hear the problem you are having.
I could do the mapping like you suggested but I was a little worried someone might want the old behavior, where the left side of the tooltip is aligned with the left side of the anchor node. I think that alignment looks good (or normal?) for TooltipDialog on desktop. I know TooltipDialog is a different widget than Tooltip, but still something to think about for comparison.
comment:8 Changed 10 years ago by
I didnt find a test in ThemeTester? that reproduced this but if you have a above-centered tooltip and display it, then display a above tooltip the connector is stil "centered" due to this if block located here:
http://bugs.dojotoolkit.org/browser/dojo/dijit/trunk/Tooltip.js#L106
if you add an else { this.connectorNode.style.left = ""; }
the problem goes away.
This keeps coming up, see #14701 and #14976. I already documented that tooltip position needs to be after-centered/before-centered, but for back-compat I'll add some code to convert after/before to after-centered/before-centered.