Opened 8 years ago

Closed 8 years ago

#15000 closed defect (patchwelcome)

Scrolling grid with slow data store results in losing focus

Reported by: jbest Owned by: Evan
Priority: undecided Milestone: 1.8
Component: DojoX Grid Version: 1.7.2
Keywords: Cc:
Blocked By: Blocking:

Description

The is specific to the enhanced grid.

Holding down page down or the down arrow results in the grid losing focus. Attaching a test case with a new SlowItemfileReadStore? I created to simulate a slower data store.

Attachments (3)

15000_test.patch (6.9 KB) - added by jbest 8 years ago.
15000.patch (775 bytes) - added by jbest 8 years ago.
15000_update.patch (2.0 KB) - added by jbest 8 years ago.

Download all attachments as: .zip

Change History (5)

Changed 8 years ago by jbest

Attachment: 15000_test.patch added

Changed 8 years ago by jbest

Attachment: 15000.patch added

comment:1 Changed 8 years ago by jbest

I was working from the 1.7.2 source. It looks like Evan committed a similar change 2 weeks ago (27984).

My patch only removes:

this.currentArea("header", true); 

Removing the focusArea call too causes the grid to not scroll back to the top and my test will fail:

this.focusArea(this._currentAreaIdx);

EDIT: The problem with _delayedCellFocus focusing the header is that it is called every time renderPage of the scroller fires. Focusing the header as you are scrolling would not be desired. Perhaps the original intention of this was to focus the header on the initial page render?

Last edited 8 years ago by jbest (previous) (diff)

comment:2 Changed 8 years ago by Evan

Milestone: tbd1.8
Resolution: patchwelcome
Status: newclosed

Thanks,

But 15000.patch will cause a similar regression as #12435, the scrolling bar will always jump back to the original focused cell which was clicked before scrolling.

Haven't figured out an ideal solution to leverage:

  1. Grid shouldn't grab focus when it's initially created or refreshed, otherwise if we were in a long page, the page will be jumped anytime grid is initially created or refreshed, that will be very annoying.
  2. Cell focus should be retained on Grid during scrolling/new page rendering


Any patches are welcomed.

Changed 8 years ago by jbest

Attachment: 15000_update.patch added
Note: See TracTickets for help on using tickets.