Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#14996 closed defect (fixed)

dojo/store/Observable modifies the original store

Reported by: Kris Zyp Owned by: Kris Zyp
Priority: undecided Milestone: 1.8
Component: Data Version: 1.7.2
Keywords: Cc:
Blocked By: Blocking:

Description

dojo/store/Observable modifies the original store, even though the signature does not suggest nor need such a modification. A side-effect free based approach would be preferable.

Change History (3)

comment:1 Changed 8 years ago by Kris Zyp

I believe the signature also suggests that it may be desirable to have the observable stores satisfy instanceof dojo.store.Observable, however I don't believe that is possible with dojo.declare, so that may need to wait for 2.0 or Compose.

comment:2 Changed 8 years ago by Kris Zyp

Owner: set to Kris Zyp
Resolution: fixed
Status: newclosed

In [28137]:

Make a new store instance when creating an observable store instead of modifying the original, fixes #14996 !strict

comment:3 Changed 8 years ago by bill

Component: GeneralData
Milestone: tbd1.8
Note: See TracTickets for help on using tickets.