Opened 8 years ago

Closed 8 years ago

#14990 closed defect (fixed)

dojo AMD loader(require), plugin(dojo/text) issues

Reported by: Eric Wang Owned by: Rawld Gill
Priority: undecided Milestone: 1.8
Component: Loader Version: 1.7.2
Keywords: Cc: cjolif, Patrick Ruzand
Blocked By: Blocking:

Description

  1. dojo AMD loader(require) sync load not trigger require.on("error") handler
  2. require cannot catch loader plugin(dojo/text) error
  3. perform is too low when loading an noexist module several times

see the attachment for the details.
Please put the test file under dojo/tests directory to test.

Attachments (1)

require.html​ (6.3 KB) - added by Eric Wang 8 years ago.

Download all attachments as: .zip

Change History (6)

Changed 8 years ago by Eric Wang

Attachment: require.html​ added

comment:1 Changed 8 years ago by cjolif

Cc: cjolif added

comment:2 Changed 8 years ago by Patrick Ruzand

Cc: Patrick Ruzand added

comment:3 Changed 8 years ago by Rawld Gill

Milestone: tbd → 1.8
Status: new → assigned

comment:4 Changed 8 years ago by Rawld Gill

In [28359]:

improved timeout in loader to watch plugin requests; added test to demonstrate this plus other, unresolved issues; refs #14990; !strict

comment:5 Changed 8 years ago by Rawld Gill

Resolution: → fixed
Status: assigned → closed

Hi EricWang?! thanks for the great test.

Unfortunately most of the issues it points out are undefined in the AMD spec. These issues are being discussed here ​http://groups.google.com/group/amd-implement/browse_thread/thread/bb47f5eb576b7490.

The third test did point out that the loader was not timing out in case a plugin resource-id failed to load. I fixed this in [28359]. As this is the only real defect, I am closing this ticket. I also opened a new ticket at #15194 to track error recovery as the spec evolves.

Note: See TracTickets for help on using tickets.