Opened 7 years ago
Closed 7 years ago
#14989 closed defect (fixed)
[cla][patch] dojo/i18n does not wait for localization preloads to complete before fetching nls bundles
| Reported by: | Colin Snover | Owned by: | Rawld Gill |
|---|---|---|---|
| Priority: | blocker | Milestone: | 1.7.3 |
| Component: | Internationalization | Version: | 1.7.2 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | #14092 |
Description
Related to #14972. dojo/i18n doesn’t wait for preloadLocalizations to successfully retrieve bundles before requesting the i18n modules which means too many requests occur. Patch attached against 1.7 branch.
Attachments (1)
Change History (11)
Changed 7 years ago by
| Attachment: | ticket-21394-2.diff added |
|---|
comment:1 Changed 7 years ago by
| Status: | new → assigned |
|---|
comment:2 Changed 7 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
comment:3 Changed 7 years ago by
| Milestone: | 1.7.3 → 1.8 |
|---|
comment:4 Changed 7 years ago by
| Milestone: | 1.8 → 1.7.3 |
|---|---|
| Resolution: | fixed |
| Status: | closed → reopened |
I put specific milestones on my tickets for a reason, Bill :)
comment:5 Changed 7 years ago by
It doesn't seem worth backporting to me, but in any case it's Rawld's decision which loader fixes are critical enough and safe enough to backport to the 1.7 branch. He just checked this one into the trunk.
comment:6 Changed 7 years ago by
| Status: | reopened → assigned |
|---|
comment:8 Changed 7 years ago by
Sorry, ignore me. #15090 is probably just a dup of this, and seems to be fixed on trunk.
comment:10 Changed 7 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
I'm transferring tracking backport to 1.7 of this ticket to #14092. The i18n fixes will either be backported in total or not at all since there is too much risk trying to backport a subset.
In [28127]: