Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#14983 closed defect (fixed)

Layout is not correct in webkit browsers and IE displays an error, when adding new TabBarButton programmatically.

Reported by: Hikaru Tamura Owned by: ykami
Priority: undecided Milestone: 1.8
Component: DojoX Mobile Version: 1.7.2
Keywords: Cc:
Blocked By: Blocking:

Description

Put attached file in to dojox/mobile/tests/.
Open it.
In Chrome. Layout is not correct.
In IE8. IE displays Error.

This sample is adding new TabBarButton? into TabBar? programmatically.

Attachments (2)

TabBar_Programmatic.html​ (1.9 KB) - added by Hikaru Tamura 8 years ago.
14983.patch​ (1.1 KB) - added by Hikaru Tamura 8 years ago.
[IBMCCLA]

Download all attachments as: .zip

Change History (5)

Changed 8 years ago by Hikaru Tamura

Attachment: TabBar_Programmatic.html​ added

comment:1 Changed 8 years ago by Hikaru Tamura

[IBMCCLA]
To fix this issue. Need to move class toggle to up. Because, it should be apply proper class before calculate margin.

Changed 8 years ago by Hikaru Tamura

Attachment: 14983.patch​ added

[IBMCCLA]

comment:2 Changed 8 years ago by ykami

Resolution: → fixed
Status: new → closed

In [28122]:

Fixes #14983 !strict. Add css classes before accessing dom dimension. Applied htamura's patch. Thanks htamura for the patch.

comment:3 Changed 8 years ago by bill

Milestone: tbd → 1.8
Note: See TracTickets for help on using tickets.