[patch][CLA] dojox/analytics/_base.js (FIXME)

[mm]

Could this be a solution for your FIXME ?

--- a/analytics/_base.js
+++ b/analytics/_base.js
@@ -43,12 +43,7 @@ define(["dojo/_base/lang", "dojo/_base/config", "dojo/ready", "dojo/_base/unload
                        //      data push
 
                        if(arguments.length > 2){
-                               // FIXME: var c = dojo._toArray(arguments) ?
-                               var c = [];
-                               for(var i = 1; i < arguments.length; i++){
-                                       c.push(arguments[i]);
-                               }
-                               data = c;
+                               data = Array.prototype.slice.call(arguments,1);
                        }
 
                        this._data.push({ plugin: dataType, data: data });

[bill]

mm, I'm not sure who you are? We can't take code unless you've filed a ​CLA.

Also, after filing a CLA please use the "attach file" button to attach patches.

[mm]

Attachment (_base.js) added by ticket reporter.

[mm]

Please: my CLA shall be OK , my email shall be visible to you, check your evidence. File attached (again) cycle changed to one line. Shall be easy to perform, if some interest shown. I do understand "the need for process", however sometimes I would expect more pragmatism, sorry for that.

[mm]

http://dojotoolkit.org/reference-guide/developer/contributors.html#individuals-who-have-signed-dojo-clas Martin Marko

Dear Martin Marko:

Welcome to the Dojo Foundation open source community!

This email confirms that your Contributor License Agreement has been received and your name has been added to the Dojo Foundation's contributor listing. Our committers are now authorized to accept your contributions to Dojo Foundation projects which currently include the Dojo Toolkit, Lucid Desktop, Persevere, CometD, DWR, Sizzle, Zarl, General Interface, Wink Toolkit, AnimeJ, RequireJS, Opencoweb and EmbedJS.

On behalf of the Dojo Foundation and its supporting communities, I want to sincerely thank you for sharing your work and knowledge in our continued efforts to keep the web open.

Thank you!

-- Aimee Evans The Dojo Foundation 800 West El Camino Real Mountain View, CA 94040 Fax: 650-618-0300 http://dojotoolkit.org

[bill]

OK, mm == Martin Marko, thanks.

[mm]

status ? please ?

[mm]

What is the reason to mark anything in code with FIXME ? Someone fixes this and noone applies the patch ? Nor replies with any coding comments ?

[dylan]

This one has a patch and CLA, looks like it works, and should make the code base a bit smaller. Marking as 1.8.

[dylan]

In [28774]:

fixes #14959, thanks mm

[dylan]

Fixed, going with the simple JS approach that works, thanks mm.