Opened 8 years ago

Closed 8 years ago

#14959 closed defect (fixed)

[patch][CLA] dojox/analytics/_base.js (FIXME)

Reported by: mm Owned by: dylan
Priority: high Milestone: 1.8
Component: Dojox Version: 1.7.2
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by bill)

Could this be a solution for your FIXME ?

--- a/analytics/_base.js
+++ b/analytics/_base.js
@@ -43,12 +43,7 @@ define(["dojo/_base/lang", "dojo/_base/config", "dojo/ready", "dojo/_base/unload
                        //      data push
 
                        if(arguments.length > 2){
-                               // FIXME: var c = dojo._toArray(arguments) ?
-                               var c = [];
-                               for(var i = 1; i < arguments.length; i++){
-                                       c.push(arguments[i]);
-                               }
-                               data = c;
+                               data = Array.prototype.slice.call(arguments,1);
                        }
 
                        this._data.push({ plugin: dataType, data: data });

Attachments (1)

_base.js (563 bytes) - added by mm 8 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 8 years ago by bill

Component: GeneralDojox
Description: modified (diff)
Owner: set to mm
Status: newpending

mm, I'm not sure who you are? We can't take code unless you've filed a CLA.

Also, after filing a CLA please use the "attach file" button to attach patches.

Changed 8 years ago by mm

Attachment: _base.js added

comment:2 Changed 8 years ago by mm

Status: pendingnew

Attachment (_base.js) added by ticket reporter.

comment:3 Changed 8 years ago by mm

Please: my CLA shall be OK , my email shall be visible to you, check your evidence. File attached (again) cycle changed to one line. Shall be easy to perform, if some interest shown. I do understand "the need for process", however sometimes I would expect more pragmatism, sorry for that.

comment:4 Changed 8 years ago by mm

http://dojotoolkit.org/reference-guide/developer/contributors.html#individuals-who-have-signed-dojo-clas Martin Marko

Dear Martin Marko:

Welcome to the Dojo Foundation open source community!

This email confirms that your Contributor License Agreement has been received and your name has been added to the Dojo Foundation's contributor listing. Our committers are now authorized to accept your contributions to Dojo Foundation projects which currently include the Dojo Toolkit, Lucid Desktop, Persevere, CometD, DWR, Sizzle, Zarl, General Interface, Wink Toolkit, AnimeJ, RequireJS, Opencoweb and EmbedJS.

On behalf of the Dojo Foundation and its supporting communities, I want to sincerely thank you for sharing your work and knowledge in our continued efforts to keep the web open.

Thank you!

-- Aimee Evans The Dojo Foundation 800 West El Camino Real Mountain View, CA 94040 Fax: 650-618-0300 http://dojotoolkit.org

comment:5 Changed 8 years ago by bill

Owner: changed from mm to Dustin Machi
Status: newassigned

OK, mm == Martin Marko, thanks.

comment:6 Changed 8 years ago by mm

status ? please ?

comment:7 Changed 8 years ago by mm

What is the reason to mark anything in code with FIXME ? Someone fixes this and noone applies the patch ? Nor replies with any coding comments ?

comment:8 Changed 8 years ago by dylan

Milestone: tbd1.8
Priority: undecidedhigh
Summary: dojox/analytics/_base.js (FIXME)[patch][CLA] dojox/analytics/_base.js (FIXME)

This one has a patch and CLA, looks like it works, and should make the code base a bit smaller. Marking as 1.8.

comment:9 Changed 8 years ago by dylan

Resolution: fixed
Status: assignedclosed

In [28774]:

fixes #14959, thanks mm

comment:10 Changed 8 years ago by dylan

Resolution: fixed
Status: closedreopened

comment:11 Changed 8 years ago by dylan

Owner: changed from Dustin Machi to dylan
Status: reopenedassigned

comment:12 Changed 8 years ago by dylan

Resolution: fixed
Status: assignedclosed

Fixed, going with the simple JS approach that works, thanks mm.

Note: See TracTickets for help on using tickets.