Opened 7 years ago

Closed 7 years ago

Last modified 6 years ago

#14954 closed defect (fixed)

IE9: dojo.connect firing duplicate keypress events

Reported by: Douglas Hays Owned by: Kris Zyp
Priority: high Milestone: 1.8
Component: Events Version: 1.6.0
Keywords: Cc:
Blocked By: Blocking:

Description

Starting with Dojo 1.6 and continuing today in trunk, pressing ENTER will generate 2 faux keypress events if you use dojo.connect. This is causing big problems with web pages that monitor keys.

Attachments (1)

connectbug.html (542 bytes) - added by Douglas Hays 7 years ago.
testcase

Download all attachments as: .zip

Change History (6)

Changed 7 years ago by Douglas Hays

Attachment: connectbug.html added

testcase

comment:1 Changed 7 years ago by Douglas Hays

Priority: undecidedhigh

Seems specific to IE9.

comment:2 Changed 7 years ago by Kris Zyp

Resolution: fixed
Status: newclosed

In [29144]:

Avoid duplicate enter keypress events, fixes #14954 !strict

comment:3 Changed 7 years ago by Kris Zyp

Milestone: tbd1.8

comment:4 Changed 6 years ago by bill

Milestone: 1.81.6.2

I'll backport this to 1.7 and 1.6.

FYI, I investigated why there's no problem opening/closing TitlePanes on IE9 in dijit/tests/test_TitlePane.html. Strangely, it's because of the <button> nodes. Seems that since they don't have a type specified, they default to type=submit, which somehow blocks the native keypress event from occurring. (There's still the faux event created by the dojo.connect() code, but it isn't followed by the real keypress event.)

comment:5 Changed 6 years ago by bill

Milestone: 1.6.21.8

I filed #16570 about the submit button problem.

On second thought, I won't backport this ticket for now, because of that problem.

Note: See TracTickets for help on using tickets.