Opened 7 years ago

Closed 5 years ago

Last modified 5 years ago

#14944 closed defect (fixed)

[patch] FloatingPanes automagically change shape & position on browser-window resize

Reported by: asdf Owned by: Colin Snover <github.com@…>
Priority: undecided Milestone: 1.5.4
Component: DojoX Layout Version: 1.7.2
Keywords: Cc:
Blocked By: Blocking:

Description

in dojox.layout.FloatingPane?.js , line 258 should be:

"dim = dim
this._currentState;"

instead of:

"dim = dim
this._naturalState;"

if anyone cares to correct it, it will fix the bug. Thanks!

Change History (11)

comment:1 Changed 7 years ago by asdf

in dojox.layout.FloatingPane.js , line 258 should be:

dim = dim || this._currentState;

instead of:

dim = dim || this._naturalState;

if anyone cares to correct it, it will fix the bug. Thanks!

comment:2 Changed 7 years ago by bill

Summary: FloatingPanes automagically change shape & position on browser-window resize[patch] FloatingPanes automagically change shape & position on browser-window resize

comment:3 Changed 7 years ago by Philippe May

I think there's still one problem. resize() is called by the resize handle only, not when the window is dragged. So when moving the pane around and then changing the size of the main window, the window jumps back erratically.

Adding somewhere in startup() the following should work:

this.subscribe("/dnd/move/stop", function() {
  this._currentState = domGeom.position(this.domNode);
});

Otherwise the fix seems to be fine.

comment:4 Changed 5 years ago by Colin Snover <github.com@…>

Owner: set to Colin Snover <github.com@…>
Resolution: fixed
Status: newclosed

In c54ddadfd71d3bec1e966a913a4c548ef5145d4c/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:5 Changed 5 years ago by Colin Snover <github.com@…>

In 2766831ea1525be761751077b933f9c716123507/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:6 Changed 5 years ago by Colin Snover <github.com@…>

In bece9cc25e55366eb4df2db41130ed2a06b5a526/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:7 Changed 5 years ago by Colin Snover <github.com@…>

In 286251fa36cc5bcbcbe64dc2bfbd862cea06d0c1/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:7 Changed 5 years ago by Colin Snover <github.com@…>

In c714c6f7254d21c669bbe6e291bef18c23b46abd/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:7 Changed 5 years ago by Colin Snover <github.com@…>

In e06bc41a561fbf0c69b0011bba56c57021e1c54a/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:8 Changed 5 years ago by Colin Snover <github.com@…>

In ce394b1794b0c873cd21908bca5d04987732aef8/dojox:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:9 Changed 5 years ago by Colin Snover

Milestone: tbd1.5.4
Note: See TracTickets for help on using tickets.