Opened 8 years ago

Closed 4 years ago

#14937 closed defect (patchwelcome)

TabContainer: tabPosition="right" with doLayout=false mispositioned

Reported by: milad Owned by: bill
Priority: low Milestone: 1.13
Component: Dijit Version: 1.7.2
Keywords: Cc:
Blocked By: Blocking:

Description

hi all
view attachment.
sorry for my poor language.

Attachments (1)

tab.html​ (949 bytes) - added by milad 8 years ago.

Download all attachments as: .zip

Change History (8)

Changed 8 years ago by milad

Attachment: tab.html​ added

comment:1 Changed 8 years ago by bill

Owner: set to milad
Status: new → pending
Summary: [regression] dijit.layout.TabContainer tabPosition="right" in RTL mode,mispositioned → TabContainer: tabPosition="right" with doLayout=false mispositioned

Thanks for the test case. The problem seems to happen in LTR mode too. The issue is using doLayout=false with tabPosition=right.

It doesn't seem like a regression; the same problem happens on 1.5. Did you find a version where this used to work? I think this just may be something we don't support.

comment:2 Changed 8 years ago by milad

Status: pending → new

hi
i use dojo 1.2 in old project and i think(maybe) every things is ok.
doLayout="false" in all dojo version works fine,doLayout is not reason this issue.
i think this problem is only misposition of tab title in tabPosition="right". 

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN" "http://www.w3.org/TR/html4/strict.dtd">
<html dir="rtl">
    <head>
        <script src="dojo172/dojo/dojo.js"
        djConfig="parseOnLoad: true">
        </script>
        <script type="text/javascript">
            dojo.require("dijit.layout.TabContainer");
            dojo.require("dijit.layout.ContentPane");
        </script>
        <link rel="stylesheet" type="text/css" href="dojo172/dijit/themes/claro/claro.css"/>
    </head>
    <body class="claro">
		<div>
			<div doLayout="false" tabPosition="right" dojoType="dijit.layout.TabContainer" style="width: 1020px;overflow:auto;">
				<div dojoType="dijit.layout.ContentPane" title="tab0">
					hello<br/>
					hello<br/>
					hello<br/>
				</div>
				<div dojoType="dijit.layout.ContentPane" title="tab1">
					hello<br/>
					hello<br/>
					hello<br/>
					hello<br/>
					hello<br/>
					hello<br/>
					hello<br/>
					hello<br/>
					hello<br/>
					hello<br/>
					hello<br/>
				</div>
			</div>
		</div>
    </body>
</html>

comment:3 Changed 8 years ago by bill

Well, I tried it against 1.2, changing claro to tundra, and it doesn't work for me. If you have a test case that runs against 1.2 I'd be interested to see it.

Again, doLayout="false" works fine, and tabPosition="right" works fine , but they don't work together.

comment:4 Changed 8 years ago by milad

you right,doLayout="false" & tabPosition="right" they don't work together.and in my old project with dojo 1.2(tabPosition="right") i set height manually. thank you for accuracy.

comment:5 Changed 8 years ago by bill

Milestone: tbd → future
Owner: changed from milad to bill
Status: new → assigned

comment:6 Changed 7 years ago by bill

Priority: undecided → low

comment:7 Changed 4 years ago by dylan

Milestone: future → 1.12
Resolution: → patchwelcome
Status: assigned → closed

Given that no one has shown interest in creating a patch in the past 3+ years, I'm closing this as patchwelcome.

Note: See TracTickets for help on using tickets.