Opened 8 years ago

Closed 7 years ago

#14934 closed defect (fixed)

mobile transitions should not specify z-index

Reported by: Douglas Hays Owned by: ykami
Priority: high Milestone: 1.8
Component: DojoX Mobile Version: 1.7.2
Keywords: Cc: Atsushi Ono, Eric Durocher
Blocked By: Blocking:

Description (last modified by Douglas Hays)

As pointed out by onoat and originally noted in:
http://groups.google.com/group/dojo-interest/browse_thread/thread/75d5dccf9a5c9672
the use of z-index in dojox/mobile/themes/common/transitions/ is overriding z-index values needed for proper rendering. I removed all the z-index entries in that directory and I didn't see any side-effects but maybe I don't know what to look for. It's not obvious how z-index should affect a transition since normally things are already being displayed properly (with their own z-index) and are usually just being slid on/off the screen by the transition.

Attachments (2)

overlay.html (3.0 KB) - added by Douglas Hays 8 years ago.
testcase from onoat
14934.patch (4.7 KB) - added by Douglas Hays 7 years ago.
remove all z-index:0

Download all attachments as: .zip

Change History (13)

comment:1 Changed 8 years ago by Douglas Hays

Cc: Atsushi Ono added
Description: modified (diff)
Priority: undecidedhigh

comment:2 Changed 8 years ago by Douglas Hays

Description: modified (diff)

comment:3 Changed 8 years ago by Douglas Hays

Description: modified (diff)

Changed 8 years ago by Douglas Hays

Attachment: overlay.html added

testcase from onoat

comment:4 Changed 8 years ago by Atsushi Ono

Doug, thanks for working on this issue. As for z-index, I think it depends on div order. For example, assuming the following div order:

<div id="view1" data-dojo-type="dojox.mobile.View"></div>
<div id="view2" data-dojo-type="dojox.mobile.View"></div>

If you remove all z-index entries in transition css files, "cover"/"coverv" animation will fail when transition from view2 to view1, and "reveal"/"revealv" will fail when transition from view1 to view2. You can try this with test_transition_animation2.html.

comment:5 Changed 8 years ago by Douglas Hays

onoat, getting rid of all z-index:0 from the transition css files seems to fix the problem and the transition tests still pass.

comment:6 Changed 7 years ago by Atsushi Ono

Doug, sorry for my late response. I tried to remove all z-index entries (z-index:0/100/-100) from the transition css files, then cover/coverv and reveal/revealv animations fail in test_transition-animation2.html in the cases I described in the previous comment.

Did you remove only z-index:0 entries and remain z-index:100/-100 entries? Could you please attach the patch if possible? Thanks.

Changed 7 years ago by Douglas Hays

Attachment: 14934.patch added

remove all z-index:0

comment:7 Changed 7 years ago by Douglas Hays

I meant only remove all z-index:0 rules. onoat, can you please test with the attached patch?

comment:8 Changed 7 years ago by Atsushi Ono

Doug, thanks for attaching the patch. I have tested it on iPhone/Android/Chrome, and it works fine on all of them. I think it has no problem.

comment:9 Changed 7 years ago by ykami

Milestone: tbd1.8
Status: newassigned

Thanks Doug for the patch. We confirmed it has no bad side-effects. I will apply the patch. Thanks onoat for the tests.

comment:10 Changed 7 years ago by ykami

Cc: Eric Durocher added

comment:11 Changed 7 years ago by ykami

Resolution: fixed
Status: assignedclosed

In [28299]:

Fixes #14934 !strict. Removed z-index:0 from the transition animation css files. Thanks Doug for the patch.

Note: See TracTickets for help on using tickets.