Changes between Initial Version and Version 1 of Ticket #14929, comment 10


Ignore:
Timestamp:
Apr 23, 2012, 2:32:44 AM (7 years ago)
Author:
bill
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #14929, comment 10

    initial v1  
    1 dohRobot.rst should definitely be updated to AMD format.   Assuming both modules (the one running robot and the one loaded by initRobot()) are AMD, the data in the iframe file should be accessed via require(), ex:
     1dohRobot.rst should definitely be updated to AMD format.   The data in the iframe file (loaded by initRobot()) should be accessed via require(), ex:
    22
    33{{{
    4 var registry = dojo.global.require("dijit/registry");
     4var registry = kernel.global.require("dijit/registry");
    55}}}
    66
    7 (The old way of calling dijit.byId() or dojo.global.dijit.byId() will probably still work, but the above syntax is future-proof.)
     7(That's assuming that registry is already loaded in the iframe.)
     8
     9The old way of calling dijit.byId() or dojo.global.dijit.byId() will probably still work, but the above syntax is future-proof.
     10
     11I thought I made a new variable for accessing the iframe's global, like robot.iframe, but I guess I didn't check that change in.   robot.iframe.require() seems clearer than kernel.global.require() to me.
     12
     13Note also that I didn't implement the plugin you suggested in comment:1.   Maybe that would be an improvement although it doesn't seem to get us much beyond the kernel.global.require() syntax.   (In your plugin suggestion I'm not sure why we need toAbsMid()?)