Opened 7 years ago

Closed 7 years ago

#14912 closed defect (fixed)

dijit/TitlePane sets arrowNode.innerHTML twice on open

Reported by: Kitson Kelly Owned by: bill
Priority: undecided Milestone: 1.8
Component: Dijit Version: 1.7.2
Keywords: Cc:
Blocked By: Blocking:

Description

This is a minor thing, but I was looking at the code and when setting open on TitlePane, I noticed it sets its arrowNode.innerHTML twice.

First is at line 157 and then it calls this._setCss() which then sets it again at line 235.

I have attached a patch which removes it at line 157.

Attachments (1)

TitlePane.js.patch​ (429 bytes) - added by Kitson Kelly 7 years ago.
Removes redundant innerHTML set

Download all attachments as: .zip

Change History (3)

Changed 7 years ago by Kitson Kelly

Attachment: TitlePane.js.patch​ added

Removes redundant innerHTML set

comment:1 Changed 7 years ago by bill

Milestone: tbd → 1.8
Owner: set to bill
Status: new → assigned

Makes sense, thanks.

comment:2 Changed 7 years ago by bill

Resolution: → fixed
Status: assigned → closed

In [28057]:

Remove redundant code to set a11y char for opened/closed pane, thanks kitsonk, fixes #14912 !strict.

Note: See TracTickets for help on using tickets.