Opened 9 years ago

Closed 9 years ago

Last modified 6 years ago

#14896 closed enhancement (fixed)

Tree: process events at Tree level not TreeNode level

Reported by: bill Owned by: bill
Priority: undecided Milestone: 1.8
Component: Dijit Version: 1.7.2
Keywords: Cc:
Blocked By: Blocking:

Description

The onmouseenter, onmouseleave, onclick, and ondblclick events could be more efficiently processed by Tree, instead of setting up handlers for each TreeNode.

Change History (7)

comment:1 Changed 9 years ago by bill

Milestone: tbd → 1.8
Owner: set to bill
Status: new → assigned

comment:2 Changed 9 years ago by bill

Resolution: → fixed
Status: assigned → closed

In [28027]:

Use event delegation for Tree, fixes #14896 !strict.

comment:3 Changed 9 years ago by bill

In [28310]:

Use the same on.selector() method for keyboard events as click events... it's more resilient for Trees with custom TreeNodes that have nested widgets, in which case the getEnclosingWidget() call might return one of the nested widgets rather than the TreeNode.

This also switches to pure use of dojo/on, which means that the keypress event is no longer normalized to mozilla behavior, so had to handle those browser differences myself.

Fixes #15153, refs #14896 !strict.

comment:4 Changed 7 years ago by Bill Keese <[email protected]…>

In 50ab5342e090e9a6c03054e01ad2fc01ac0e6c1b/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?

comment:5 Changed 7 years ago by Bill Keese <[email protected]…>

In 709054a4a415314ad102858e3e9d14e11a103f38/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?

comment:6 Changed 7 years ago by Bill Keese <[email protected]…>

In 0f212ec839511767f18d6ead9f70c81ee8448cff/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?

comment:7 Changed 6 years ago by Bill Keese <[email protected]…>

In 2b8acb647169c38dbe2c3d6e3f569c0847d4ea29/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?
Note: See TracTickets for help on using tickets.