Opened 8 years ago
Closed 8 years ago
#14882 closed defect (fixed)
dojo.cldr.monetary unnecessarily includes Dojo base [patch]
Reported by: | Stefan Bird | Owned by: | bill |
---|---|---|---|
Priority: | undecided | Milestone: | 1.8 |
Component: | General | Version: | 1.7.2 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
On dojo/cldr/monetary.js:1 it imports dojo/main, when it only needs dojo/_base/lang. This means that Nano builds that use monetary will pull in dojo/main.js, negating the advantages of a Nano build.
Attachments (1)
Change History (3)
Changed 8 years ago by
Attachment: | monetary.js.patch added |
---|
comment:1 Changed 8 years ago by
Milestone: | tbd → 1.8 |
---|
comment:2 Changed 8 years ago by
Owner: | set to bill |
---|---|
Resolution: | → fixed |
Status: | new → closed |
In [28003]:
Note: See
TracTickets for help on using
tickets.
The patch is a bit out of date but I'll check in the essence of it, thanks for catching the problem.
Let us know if you see any other problems, although if you have any significant patches (more than a few lines) please file a cla first.