Opened 7 years ago

Closed 7 years ago

#14869 closed defect (wontfix)

Chrome bug v17 on date.setHours - dojo.date.compare and Calendar/CalendarLite

Reported by: Mathevet julien Owned by:
Priority: undecided Milestone: tbd
Component: General Version: 1.7.2
Keywords: Cc:
Blocked By: Blocking:

Description

windows Chrome v17 throw an exception:

 TypeError: this is not a Date object

You could reproduce on windows Chrome v17 with a slow computer. Use test_Calendar.html and click many time on next/previous month

See also open issue on chrome: http://code.google.com/p/v8/issues/detail?id=1945

Attachments (2)

CalendarLite.js-setHoursFix.patch (1.1 KB) - added by Mathevet julien 7 years ago.
date.js-setHoursFix.patch (569 bytes) - added by Mathevet julien 7 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 7 years ago by Mathevet julien

See also fix by doughays on TimePicker? In [27946] #14759

Changed 7 years ago by Mathevet julien

Changed 7 years ago by Mathevet julien

Attachment: date.js-setHoursFix.patch added

comment:2 Changed 7 years ago by Adam Peller

It sounds like the Chromium team has addressed the bug, so I suggest 'wontfix'. The alternative constructor seems ok in the dijit case, but does it work in all browsers? I don't recall ever seeing docs for this. As for date, calling the Date constructor is likely more expensive than setHours.

comment:3 Changed 7 years ago by bill

Resolution: wontfix
Status: newclosed

I'm on the fence about whether that change is an improvement for dijit or not, but let's go with your advice and close as wontfix.

Note: See TracTickets for help on using tickets.