[patch] Issue with HorizontalRangeSlider within a BorderContainer with a leading region

[jeetesh_n]

I've a HorizontalRangeSlider widget within the bottom region of a BorderContainer. I can select the right & left handle of the slider and vary the range. However if i click between the handles i.e. on the bar and move it, the bar doesn't follow the mouse cursor position.

My BorderContainer has a leading region. If i hide this leading region then the Horizontal slider bar moves along the mouse cursor. It seems that the pixel co-ordinates that are calculated within the RangeSlider? are not relative to a region of the bordercontainer.

This was working fine in Dojo 1.6.

I've attached a test example. I've modified the existing /dijit/tests/layout/test_BorderContainer_full.html to reproduce this issue.

Thanks, Jeetesh

[bill]

I can't get clicking between the handles to do anything, not even against 1.6, not even if I hide the leading region before creating the RangeSlider. At least not on FF11/mac.

[jeetesh_n]

Slider default value set to [40,60]

[jeetesh_n]

Attachment (test_BorderContainer_slider.2.html) added by ticket reporter.

I tested it on FF10.0 on windows and it works.

I've added a new attachment, only a single line change where i'm giving the slider a default value of [40,60].

If this works, you will notice that while moving the bar (the region between the two handles) the mouse cursor jumps way left to the left-most handle. The bar still moves but the mouse cursor is not between the two handles. If the leading pane of the bordercontainer is hidden, the bar moves and the mouse cursor stays between the two handles.

Let me know if this doesn't work. Thanks.

[bill]

What do you mean by "moving the bar"?

[jeetesh_n]

Well i meant moving the horizontal slider.

Click the area between the two handle (i called it 'bar', sorry, i don't know whats the right term) and while its clicked move the mouse. The slider then moves horizontally.

[bill]

I'm still confused. If you mouse-down at 45, then mouse-move to 55, and then mouse-up, what is supposed to happen? The slider range gets reset to 45-55?

And when you say "The slider then moves horizontally", are you talking about the slider handles moving? Or the whole slider?

[jeetesh_n]

In this example, default position is [40,60]. 1) Mouse down at 45 2) Mouse move to 50 3) The whole slider moved to [70,90]. My mouse is still down, this is the issue i'm seeing.

[bill]

Ah I see, thanks. So by dragging the blue bar between the two handles, you are moving both handles equally, plus the bar between them.

The SliderBarMover code in RangeSlider.js is very strange; looks like it should all be rewritten, to compare e.pageX at the start of the drag and on mouse move, to get a delta to move the sliders. There shouldn't be any calls to domGeometry.position(), except maybe to get the width of the bar.

[jeetesh_n]

Is any more inputs required from me. Is it possible to assign this bug to the original author of this component. Thanks.

[jeetesh_n]

patch to solve this issue

[jeetesh_n]

Dojo 1.7 replaced dojo.coords with domGeometry.position. The later returns absolute values and hence removed the extra subtraction of abspos[widget._startingPixelCoord]

[bill]

Probably also fixes #15493. Not sure if jeetesh_n has a CLA but the patch is trivial (just one line).

[Douglas Hays]

In [28775]:

Fixes #15493, #14852. Correct touch/mouse press location.