Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#14848 closed defect (fixed)

_SelectionPreserver._selectById ignores onCanDeselect result

Reported by: ractive Owned by: Evan
Priority: undecided Milestone: 1.8
Component: DojoX Grid Version: 1.7.1
Keywords: Cc:
Blocked By: Blocking:

Description

The _SelectionPreserver creates an after advice on the deselect method of the selection object and marks the row that has been handled by the deselect method always as "deselected". But the deselect method can return without actually deselecting a row when onCanDeselect returns false.

The _SelectionPreserver should listen to events like onDeselected, onSelected etc. instead of using after advices.

Change History (2)

comment:1 Changed 7 years ago by Evan

Resolution: fixed
Status: newclosed

In [29271]:

Fixes #14848 !strict, by listening to onSelected/onDeselected

comment:2 Changed 7 years ago by Evan

Milestone: tbd1.8
Note: See TracTickets for help on using tickets.