Opened 9 years ago
Closed 6 years ago
#14842 closed defect (fixed)
Dojo dnd avatar header text always show a number.
Reported by: | jactive | Owned by: | Eugene Lazutkin |
---|---|---|---|
Priority: | undecided | Milestone: | 1.8 |
Component: | DnD | Version: | 1.7.2 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
var dndTarget = new Source(this.canvas, {
"creator" : function(data, hint) { ... }, "withHandles" : true, "generateText" : false
});
The generateText is specified to false. But dojo still generate avatar header which is not expected.
In the function update() of avatar.js, the codes looks like node.innerHTML = this._generateText();. I think it should be change to node.innerHTML = this.manager.source.generateText ? this._generateText() : "";
Be more specific. This issue happens in both dojo1.71 and dojo1.72. 1.71 dojo/dnd/Avatar.js, line 111 1.72 dojo/dnd/Avatar.js, line 101
Thanks.
Change History (1)
comment:1 Changed 6 years ago by
Milestone: | tbd → 1.8 |
---|---|
Resolution: | → fixed |
Status: | new → closed |
Note: See
TracTickets for help on using
tickets.
This was fixed in 1.8.0, but never marked as fixed as the wrong ticket was cross-referenced.
https://github.com/dojo/dojo/commit/b3bb9b742bc411899e314c08042f536a42f6842b#diff-d78f217124fa9ad4e67e4e6b638fcf02