Opened 7 years ago

Closed 7 years ago

#14837 closed enhancement (fixed)

dnd.css needs to be aligned with the themes

Reported by: Jean-Rubin Leonard Owned by: bill
Priority: undecided Milestone: 1.8
Component: themes Version: 1.7.2
Keywords: Cc:
Blocked By: Blocking:

Description

the dnd.css that controls the styling for dnd operations as well as items selection (dojo.dnd.Selector) should be aligned with the four big themes (claro, nihilo, soria and tundra). Currently the css stands in its own but when we use it in one or the other theme, it needs to be heavily edited to align the look and feel of the selection or the DnD with the used theme. Of course if we change to use another theme, the DnD's CSS needs to be changed. These tweakings would need to be reworked every time there's a change in the CSS of any of the four themes. If the dnd.css was forked along the four themes these editing would not be necessary.

Attachments (1)

treetestdnd.html (1.5 KB) - added by Jean-Rubin Leonard 7 years ago.
tree and dnd nodes side by side to test styling

Download all attachments as: .zip

Change History (7)

comment:1 Changed 7 years ago by bill

Owner: changed from nonken to Jean-Rubin Leonard
Status: newpending

The themes already have CSS for DnD. Perhaps dnd.css should just be removed, but that's a separate issue. What problem are you seeing specifically?

comment:2 Changed 7 years ago by Jean-Rubin Leonard

Status: pendingnew

if i create a dojo.dnd.Selector node and select a node in it, the styling of the selected node is completely different from that of the currently used theme. Could you point me to where the styling for the DnD is supposed to be so I can double check a few things? Thanks.

comment:3 Changed 7 years ago by bill

Status: newpending

Well, if I do a

$ cd dijit/themes
$ grep  -i dnd $(find . -name '*.css')

I get 72 lines.

Probably there's no CSS for selected node? You were looking for the gradient background like when claro selects nodes in a Tree, or perhaps rows in a grid? Also, please attach your test case to make sure we are looking at the same thing.

Changed 7 years ago by Jean-Rubin Leonard

Attachment: treetestdnd.html added

tree and dnd nodes side by side to test styling

comment:4 Changed 7 years ago by Jean-Rubin Leonard

Status: pendingnew

Attachment (treetestdnd.html) added by ticket reporter.

comment:5 Changed 7 years ago by bill

Milestone: tbd1.8
Owner: changed from Jean-Rubin Leonard to bill
Status: newassigned

Thanks for the test case. You didn't specify exactly what is lacking but from looking at the test case it appears to just be the styling for selection (ie, that selected rows in a dojo.dnd.Selector don't have any styling).

comment:6 Changed 7 years ago by bill

Resolution: fixed
Status: assignedclosed

In [27951]:

Make claro style for hovered and selected DnD items the same as it styles hovered and selected Tree rows.

For tundra, and soria, using the same background color for selected DnD items and selected Tree rows, but the styling looks different because tundra and soria only style the Tree label rather than the whole Tree row.

Nihilo has no style for selected Tree rows, so just doing hover style.

Fixes #14837 !strict.

Note: See TracTickets for help on using tickets.