Opened 7 years ago

Closed 7 years ago

Last modified 6 years ago

#14835 closed enhancement (fixed)

implement mobile/SearchBox widget

Reported by: Douglas Hays Owned by: Douglas Hays
Priority: high Milestone: 1.8
Component: DojoX Mobile Version: 1.7.2
Keywords: contactsapp Cc: ykami, Atsushi Ono, koba
Blocked By: Blocking:

Description

dojox/mobile needs a SearchBox? widget that looks and behaves like
INPUT type=search
but can search Dojo's date stores. Results will be returned but not displayed by this widget.

Attachments (6)

SearchBox.patch (27.1 KB) - added by Douglas Hays 7 years ago.
initial implementation for review
SearchBox.jpg (1.5 KB) - added by Douglas Hays 7 years ago.
SearchBoxThemePatch.txt (15.7 KB) - added by koba 7 years ago.
[IBM CCLA] theme files for SearchBox?
SearchBoxTheme.patch (15.7 KB) - added by koba 7 years ago.
I modified file extension. Please delete the previous patch.
test_SearchBox-demo.patch (8.6 KB) - added by Adrian Vasiliu 7 years ago.
Adrian Vasiliu, IBM, CCLA
test_SearchBox-demo-new.patch (5.8 KB) - added by Adrian Vasiliu 7 years ago.
Improved version to use dojo/store consistenly, and some minor cleanup - Adrian Vasiliu, IBM, CCLA

Download all attachments as: .zip

Change History (23)

Changed 7 years ago by Douglas Hays

Attachment: SearchBox.patch added

initial implementation for review

comment:1 Changed 7 years ago by Douglas Hays

Cc: ykami added
Milestone: tbd1.8
Owner: changed from ykami to Douglas Hays
Priority: undecidedhigh
Status: newassigned

ykami, can you please review this patch? I included only prototype CSS in the test_FormControls.html file just to show a crude representation of the expected search decorations. Desktop browsers that do not understand type=search will fallback to a simple textbox (with optionally supported placeHolder seearch text) but searching will still work. I forced IOS 4 to not display a cancel X to the right since it doesn't fire an event when this is clicked and it's not worth a lot of code to overlay the textbox with another DIV just for IOS4 since the overall function is barely diminished and this is fixed in IOS 5 (and already works on all other webkit browsers include Android 2.3+, Blackberry and of course Chrome).

Changed 7 years ago by Douglas Hays

Attachment: SearchBox.jpg added

comment:2 Changed 7 years ago by Douglas Hays

comment:3 Changed 7 years ago by ykami

Cc: Atsushi Ono added

comment:4 Changed 7 years ago by Douglas Hays

In [27966]:

Refs #14835. Add initial mobile/SearchBox widget. Refactor AutoCompleterMixin? to create _SearchMixin. Prototype SearchBox? CSS in test_FormControls.html needs to be pulled out and themed.

comment:5 Changed 7 years ago by Douglas Hays

In [27970]:

Refs #14835. Fixes AutoCompleterMixin?.html. Using a DataList? was mistakenly preselecting the first item but that behavior only applies to inline OPTION tags, so now the default is blank like with other data stores.

comment:6 Changed 7 years ago by bill

Note that ComboBox_a11y.html and FilteringSelect_a11y.html are still broken.

comment:7 Changed 7 years ago by cjolif

Keywords: contactsapp added

Changed 7 years ago by koba

Attachment: SearchBoxThemePatch.txt added

[IBM CCLA] theme files for SearchBox?

Changed 7 years ago by koba

Attachment: SearchBoxTheme.patch added

I modified file extension. Please delete the previous patch.

comment:8 Changed 7 years ago by Douglas Hays

Cc: koba added

comment:9 Changed 7 years ago by Douglas Hays

In [27989]:

Refs #14835. Add device-specific CSS for widget/SearchBox.

comment:10 Changed 7 years ago by Douglas Hays

koba, the SearchBox? is not as tall as a plain TextBox?.

comment:11 Changed 7 years ago by Douglas Hays

In [28066]:

Refs #14835. Test was using ctrl+X instead of down arrow to select first dropdown item.

comment:12 Changed 7 years ago by Douglas Hays

Resolution: fixed
Status: assignedclosed

In [28092]:

Fixes #14835. Fix tests to assume ENTER submits the form whenever a drop down menu item is not highlighted.

comment:13 Changed 7 years ago by Adrian Vasiliu

The attached test_SearchBox-demo.patch includes:

  1. New file: dojox/mobile/tests/test_SearchBox-demo.html This shows a dojox.mobile.SearchBox used for filtering a data store which content is displayed by a dojox.mobile.EdgeToEdgeDataList, and a dojox.mobile.SimpleDialog for customizing the search options.
  2. Modified file: dojox/mobile/tests/index.js Modified to add the new test.

We might also add a view for SearchBox into the mobileGallery.

Last edited 7 years ago by Adrian Vasiliu (previous) (diff)

Changed 7 years ago by Adrian Vasiliu

Attachment: test_SearchBox-demo.patch added

Adrian Vasiliu, IBM, CCLA

comment:14 Changed 7 years ago by Douglas Hays

In [28648]:

Refs #14835. Proxy commit for Adrian. Add mobile/SearchBox demo.

comment:15 Changed 7 years ago by Adrian Vasiliu

Thanks for the commit, doughays.

Changed 7 years ago by Adrian Vasiliu

Improved version to use dojo/store consistenly, and some minor cleanup - Adrian Vasiliu, IBM, CCLA

comment:16 Changed 6 years ago by Douglas Hays

In [30191]:

Refs #14835, #16181. Proxy commit for Adrian (IBM, CCLA). Optimize test_SearchBox-demo.html to use dojo/store/Memory instead of ItemFileReadStore?+DataStore?.

comment:17 Changed 6 years ago by bill

In [30409]:

remove unused dependencies, refs #14835 (specifically [27966]) !strict

Note: See TracTickets for help on using tickets.