Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#14826 closed defect (fixed)

[patch] ResizeHandle fails for dir=rtl

Reported by: Douglas Hays Owned by: haysmark
Priority: blocker Milestone: 1.8
Component: DojoX Layout Version: 1.6.0
Keywords: needsreview Cc: liucougar
Blocked By: Blocking:

Description

Change test_ResizeHandle.html to include dir=rtl on the HTML element. Run on any browser. Some dialogs have the resize handle in the bottom left as expected, others in the bottom right (unexpected, and pointing to the left). In the 2nd dialog, drag from left to right and the dialog shrinks right to left (wrong). In the 2nd red-bordered dialog, drag from right (wrong placement) to left and it grows left to right (wrong).

Attachments (2)

14826.patch​ (2.1 KB) - added by Douglas Hays 8 years ago.
possible fix, needs review
14826_17x.patch​ (1.9 KB) - added by Douglas Hays 8 years ago.
patch against 1.7/trunk

Download all attachments as: .zip

Change History (11)

comment:1 Changed 8 years ago by Douglas Hays

Cc: liucougar added
Priority: undecided → high

liucougar, can you own this ticket?

Changed 8 years ago by Douglas Hays

Attachment: 14826.patch​ added

possible fix, needs review

comment:2 Changed 8 years ago by Douglas Hays

Status: new → open
Summary: ResizeHandle fails for dir=rtl → [patch] ResizeHandle fails for dir=rtl

Changed 8 years ago by Douglas Hays

Attachment: 14826_17x.patch​ added

patch against 1.7/trunk

comment:3 Changed 8 years ago by Douglas Hays

Milestone: tbd → 1.8

liucougar, I attached a patch that can be applied against trunk. Can you please verify it works OK?

comment:4 Changed 8 years ago by haysmark

Keywords: needsreview added
Priority: high → blocker

This is definitely still a huge problem.

comment:5 Changed 8 years ago by haysmark

I'm not seeing any difference as the result of the 1.7 patch. Tested in Chrome 18.

Last edited 8 years ago by haysmark (previous) (diff)

comment:6 Changed 8 years ago by haysmark

Owner: set to haysmark
Status: open → assigned

comment:7 Changed 8 years ago by haysmark

I was able to reproduce the behavior in IE9, but not Chrome.

comment:8 Changed 8 years ago by haysmark

Resolution: → fixed
Status: assigned → closed

In [28950]:

Fix drag box dragging in opposite direction on IE9 in RTL. Fixes #14826.

comment:9 Changed 8 years ago by haysmark

Version: 1.7.2 → 1.6.0
Note: See TracTickets for help on using tickets.